feat: do not start indexer service (back port: tendermint#3331) (tendermint#3496)

if block && tx indexers are no-op

---------

Co-authored-by: Anton Kaliaev <[email protected]>

Author: mmsqe

node/node.go

@@ -592,10 +592,11 @@ func (n *Node) OnStop() {
 	if err := n.eventBus.Stop(); err != nil {
 		n.Logger.Error("Error closing eventBus", "err", err)
 	}
-	if err := n.indexerService.Stop(); err != nil {
-		n.Logger.Error("Error closing indexerService", "err", err)
+	if n.indexerService != nil {
+		if err := n.indexerService.Stop(); err != nil {
+			n.Logger.Error("Error closing indexerService", "err", err)
+		}
 	}
-
 	// now stop the reactors
 	if err := n.sw.Stop(); err != nil {
 		n.Logger.Error("Error closing switch", "err", err)

node/setup.go

@@ -149,16 +149,20 @@ func createAndStartIndexerService(
 		txIndexer    txindex.TxIndexer
 		blockIndexer indexer.BlockIndexer
 	)
-	txIndexer, blockIndexer, err := block.IndexerFromConfig(config, dbProvider, chainID)
+
+	txIndexer, blockIndexer, allIndexersDisabled, err := block.IndexerFromConfigWithDisabledIndexers(config, dbProvider, chainID)
 	if err != nil {
 		return nil, nil, nil, err
 	}
+	if allIndexersDisabled {
+		return nil, txIndexer, blockIndexer, nil
+	}
 
 	txIndexer.SetLogger(logger.With("module", "txindex"))
 	blockIndexer.SetLogger(logger.With("module", "txindex"))
+
 	indexerService := txindex.NewIndexerService(txIndexer, blockIndexer, eventBus, false)
 	indexerService.SetLogger(logger.With("module", "txindex"))
-
 	if err := indexerService.Start(); err != nil {
 		return nil, nil, nil, err
 	}

state/indexer/block/indexer.go

@@ -16,32 +16,42 @@ import (
 	"github.com/cometbft/cometbft/state/txindex/null"
 )
 
-// EventSinksFromConfig constructs a slice of indexer.EventSink using the provided
+// IndexerFromConfig constructs a slice of indexer.EventSink using the provided
 // configuration.
-//
-//nolint:lll
-func IndexerFromConfig(cfg *config.Config, dbProvider config.DBProvider, chainID string) (txindex.TxIndexer, indexer.BlockIndexer, error) {
+func IndexerFromConfig(cfg *config.Config, dbProvider config.DBProvider, chainID string) (
+	txIdx txindex.TxIndexer, blockIdx indexer.BlockIndexer, err error,
+) {
+	txidx, blkidx, _, err := IndexerFromConfigWithDisabledIndexers(cfg, dbProvider, chainID)
+	return txidx, blkidx, err
+}
+
+// IndexerFromConfigWithDisabledIndexers constructs a slice of indexer.EventSink using the provided
+// configuration. If all indexers are disabled in the configuration, it returns null indexers.
+// Otherwise, it creates the appropriate indexers based on the configuration.
+func IndexerFromConfigWithDisabledIndexers(cfg *config.Config, dbProvider config.DBProvider, chainID string) (
+	txIdx txindex.TxIndexer, blockIdx indexer.BlockIndexer, allIndexersDisabled bool, err error,
+) {
 	switch cfg.TxIndex.Indexer {
 	case "kv":
 		store, err := dbProvider(&config.DBContext{ID: "tx_index", Config: cfg})
 		if err != nil {
-			return nil, nil, err
+			return nil, nil, false, err
 		}
 
-		return kv.NewTxIndex(store), blockidxkv.New(dbm.NewPrefixDB(store, []byte("block_events"))), nil
+		return kv.NewTxIndex(store), blockidxkv.New(dbm.NewPrefixDB(store, []byte("block_events"))), false, nil
 
 	case "psql":
 		conn := cfg.TxIndex.PsqlConn
 		if conn == "" {
-			return nil, nil, errors.New("the psql connection settings cannot be empty")
+			return nil, nil, false, errors.New("the psql connection settings cannot be empty")
 		}
 		es, err := psql.NewEventSink(cfg.TxIndex.PsqlConn, chainID)
 		if err != nil {
-			return nil, nil, fmt.Errorf("creating psql indexer: %w", err)
+			return nil, nil, false, fmt.Errorf("creating psql indexer: %w", err)
 		}
-		return es.TxIndexer(), es.BlockIndexer(), nil
+		return es.TxIndexer(), es.BlockIndexer(), false, nil
 
 	default:
-		return &null.TxIndex{}, &blockidxnull.BlockerIndexer{}, nil
+		return &null.TxIndex{}, &blockidxnull.BlockerIndexer{}, true, nil
 	}
 }