Skip to content

Commit 562bcfd

Browse files
iKapitonauiKapitonau
committed
Merge tag 'v0.38.12' into cometbft-0.38.9
Tagged v0.38.12 release
2 parents 847cc73 + 9722b6d commit 562bcfd

40 files changed

+705
-335
lines changed

‎.changelog/v0.38.11/bug-fixes/3528-evidence-missing-json-tags.md

Lines changed: 0 additions & 2 deletions
This file was deleted.

‎.changelog/v0.38.12/bug-fixes/0016-abc-light-proposer-priorities.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
- `[light]` Cross-check proposer priorities in retrieved validator sets
2+
([\#ASA-2024-009](https://github.com/cometbft/cometbft/security/advisories/GHSA-g5xx-c4hv-9ccc))

‎.changelog/v0.38.12/bug-fixes/3828-privval-drop-duplicate-listen.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- `[privval]` Ignore duplicate privval listen when already connected ([\#3828](https://github.com/cometbft/cometbft/issues/3828)

‎.changelog/v0.38.12/dependencies/3728-update-btcec-v2.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
- `[crypto/secp256k1]` Adjust to breaking interface changes in
2+
`btcec/v2` latest release, while avoiding breaking changes to
3+
local CometBFT functions
4+
([\#3728](https://github.com/cometbft/cometbft/pull/3728))

‎.changelog/v0.38.12/improvements/0016-abc-types-validator-set.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
- `[types]` Check that proposer is one of the validators in `ValidateBasic`
2+
([\#ASA-2024-009](https://github.com/cometbft/cometbft/security/advisories/GHSA-g5xx-c4hv-9ccc))

‎.changelog/v0.38.12/improvements/3819-e2e-log-level.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
- `[e2e]` Add `log_level` option to manifest file
2+
([#3819](https://github.com/cometbft/cometbft/pull/3819)).

‎.changelog/v0.38.12/improvements/3836-e2e-log-format.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
- `[e2e]` Add `log_format` option to manifest file
2+
([#3836](https://github.com/cometbft/cometbft/issues/3836)).

‎.changelog/v0.38.12/summary.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
*September 3, 2024*
2+
3+
This release includes a security fix for the light client and is recommended
4+
for all users.

‎.github/workflows/cometbft-docker.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
password: ${{ secrets.DOCKERHUB_TOKEN }}
5252

5353
- name: Publish to Docker Hub
54-
uses: docker/build-push-action@v6.6.1
54+
uses: docker/build-push-action@v6.7.0
5555
with:
5656
context: .
5757
file: ./DOCKER/Dockerfile

‎.github/workflows/proto-lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
timeout-minutes: 5
1616
steps:
1717
- uses: actions/checkout@v4
18-
- uses: bufbuild/buf-setup-action@v1.36.0
18+
- uses: bufbuild/buf-setup-action@v1.38.0
1919
- uses: bufbuild/buf-lint-action@v1
2020
with:
2121
input: 'proto'

‎.github/workflows/testapp-docker.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
password: ${{ secrets.DOCKERHUB_TOKEN }}
5252

5353
- name: Publish to Docker Hub
54-
uses: docker/build-push-action@v6.6.1
54+
uses: docker/build-push-action@v6.7.0
5555
with:
5656
context: .
5757
file: ./test/e2e/docker/Dockerfile

‎.golangci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ linters:
66
- dogsled
77
- dupl
88
- errcheck
9-
- exportloopref
9+
# - copyloopvar
1010
- goconst
1111
- gofmt
1212
- goimports
13-
- gosec
13+
# - gosec
1414
- gosimple
1515
- govet
1616
- ineffassign

‎CHANGELOG.md

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,34 @@
11
# CHANGELOG
22

3+
## v0.38.12
4+
5+
*September 3, 2024*
6+
7+
This release includes a security fix for the light client and is recommended
8+
for all users.
9+
10+
### BUG FIXES
11+
12+
- `[light]` Cross-check proposer priorities in retrieved validator sets
13+
([\#ASA-2024-009](https://github.com/cometbft/cometbft/security/advisories/GHSA-g5xx-c4hv-9ccc))
14+
- `[privval]` Ignore duplicate privval listen when already connected ([\#3828](https://github.com/cometbft/cometbft/issues/3828)
15+
16+
### DEPENDENCIES
17+
18+
- `[crypto/secp256k1]` Adjust to breaking interface changes in
19+
`btcec/v2` latest release, while avoiding breaking changes to
20+
local CometBFT functions
21+
([\#3728](https://github.com/cometbft/cometbft/pull/3728))
22+
23+
### IMPROVEMENTS
24+
25+
- `[types]` Check that proposer is one of the validators in `ValidateBasic`
26+
([\#ASA-2024-009](https://github.com/cometbft/cometbft/security/advisories/GHSA-g5xx-c4hv-9ccc))
27+
- `[e2e]` Add `log_level` option to manifest file
28+
([#3819](https://github.com/cometbft/cometbft/pull/3819)).
29+
- `[e2e]` Add `log_format` option to manifest file
30+
([#3836](https://github.com/cometbft/cometbft/issues/3836)).
31+
332
## v0.38.11
433

534
*August 12, 2024*
@@ -12,8 +41,6 @@ It also includes a few other bug fixes and performance improvements.
1241

1342
### BUG FIXES
1443

15-
- `[types]` Added missing JSON tags to `DuplicateVoteEvidence` and `LightClientAttackEvidence`
16-
types ([\#3528](https://github.com/cometbft/cometbft/issues/3528))
1744
- `[types]` Only check IFF vote is a non-nil Precommit if extensionsEnabled
1845
types ([\#3565](https://github.com/cometbft/cometbft/issues/3565))
1946

‎Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ endif
135135
#? proto-gen: Generate protobuf files
136136
proto-gen: check-proto-deps
137137
@echo "Generating Protobuf files"
138-
@go run github.com/bufbuild/buf/cmd/buf generate
138+
@go run github.com/bufbuild/buf/cmd/buf@latest generate
139139
@mv ./proto/tendermint/abci/types.pb.go ./abci/types/
140140
@cp ./proto/tendermint/rpc/grpc/types.pb.go ./rpc/grpc
141141
.PHONY: proto-gen
@@ -145,7 +145,7 @@ proto-gen: check-proto-deps
145145
#? proto-lint: Lint protobuf files
146146
proto-lint: check-proto-deps
147147
@echo "Linting Protobuf files"
148-
@go run github.com/bufbuild/buf/cmd/buf lint
148+
@go run github.com/bufbuild/buf/cmd/buf@latest lint
149149
.PHONY: proto-lint
150150

151151
#? proto-format: Format protobuf files
@@ -160,11 +160,11 @@ proto-check-breaking: check-proto-deps
160160
@echo "Note: This is only useful if your changes have not yet been committed."
161161
@echo " Otherwise read up on buf's \"breaking\" command usage:"
162162
@echo " https://docs.buf.build/breaking/usage"
163-
@go run github.com/bufbuild/buf/cmd/buf breaking --against ".git"
163+
@go run github.com/bufbuild/buf/cmd/buf@latest breaking --against ".git"
164164
.PHONY: proto-check-breaking
165165

166166
proto-check-breaking-ci:
167-
@go run github.com/bufbuild/buf/cmd/buf breaking --against $(HTTPS_GIT)#branch=v0.34.x
167+
@go run github.com/bufbuild/buf/cmd/buf@latest breaking --against $(HTTPS_GIT)#branch=v0.34.x
168168
.PHONY: proto-check-breaking-ci
169169

170170
###############################################################################

‎crypto/secp256k1/secp256k1.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,8 @@ func GenPrivKeySecp256k1(secret []byte) PrivKey {
128128
func (privKey PrivKey) Sign(msg []byte) ([]byte, error) {
129129
priv, _ := secp256k1.PrivKeyFromBytes(privKey)
130130

131-
sig, err := ecdsa.SignCompact(priv, crypto.Sha256(msg), false)
132-
if err != nil {
133-
return nil, err
134-
}
131+
sum := sha256.Sum256(msg)
132+
sig := ecdsa.SignCompact(priv, sum[:], false)
135133

136134
// remove the first byte which is compactSigRecoveryCode
137135
return sig[1:], nil

0 commit comments

Comments
 (0)