Revm error: [SCROLL] Failed to load transaction rlp_bytes

[georgehao]

Describe the bug

Call scroll-reth eth_estimateGas, the API report an error

{"jsonrpc":"2.0","id":1,"error":{"code":-32603,"message":"Revm error: [SCROLL] Failed to load transaction rlp_bytes."}}

Steps to reproduce

1. use branch feat/scroll-rpc1
2. run scroll-reth

RUST_LOG=debug cargo run --bin scroll-reth --features "scroll,skip-state-root-validation" --manifest-path crates/scroll/bin/scroll-reth/Cargo.toml -- node --chain scroll-mainnet --debug.tip 0x6f2012d9a1bf955bd768b2626ab5f10dd0b31535c47502eeb630138fc19942de  --http --http.addr 0.0.0.0 --http.port 8545 --http.api all --datadir  ./datadir

3. call eth_estimateGas

curl http://127.0.0.1:8545 -X POST -H "Content-Type: application/json"  --data '{"method":"eth_estimateGas","params":[{"to":"0x9fE46736679d2D9a65F0992F2272dE9f3c7fa6e0"}],"id":1,"jsonrpc":"2.0"}'

Node logs

no log from node

Platform(s)

Mac (Apple Silicon)

Container Type

Not running in a container

What version/commit are you on?

#136

What database version are you on?

dev

Which chain / network are you on?

dev

What type of node are you running?

Archive (default)

What prune config do you use, if any?

No response

If you've built Reth from source, provide the full command you used

RUST_LOG=debug cargo run --bin scroll-reth --features "scroll,skip-state-root-validation" --manifest-path crates/scroll/bin/scroll-reth/Cargo.toml -- node --chain scroll-mainnet --debug.tip 0x6f2012d9a1bf955bd768b2626ab5f10dd0b31535c47502eeb630138fc19942de --http --http.addr 0.0.0.0 --http.port 8545 --http.api all --datadir ./datadir

Code of Conduct

• I agree to follow the Code of Conduct

[greged93]

I think the issue comes from the a missing implementation of the Call trait for ScrollEthApi. You can find the equivalent implementation for OpEthApi here. You need to implement the Call trait in a similar fashion as Optimism and set the scroll field of the TxEnv to the correct value.

[georgehao]

I think I implemented it https://github.com/scroll-tech/reth/blob/58c2b50616812f89424022b5c9667a6d10ad0c09/crates/scroll/rpc/src/eth/call.rs

[greged93]

Ok perfect, we just need to ensure the scroll field isn't set to Default