Skip to content

Commit c7146c1

Browse files
committed
Remove opening height from round context: duplicate of log2_height
1 parent dc978b6 commit c7146c1

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

src/basefold_verifier/query_phase.rs

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,6 @@ pub struct RoundContextVariable<C: Config> {
316316
pub(crate) log2_heights: Array<C, Var<C::N>>,
317317
pub(crate) minus_alpha_offsets: Array<C, Ext<C::F, C::EF>>,
318318
pub(crate) all_zero_slices: Array<C, Array<C, Ext<C::F, C::EF>>>,
319-
pub(crate) opening_heights: Array<C, Var<C::N>>,
320319
pub(crate) dimensions: Array<C, Var<C::N>>,
321320
}
322321

@@ -408,7 +407,6 @@ pub(crate) fn batch_verifier_query_phase<C: Config>(
408407
let log2_heights = builder.dyn_array(round.openings.len());
409408
let minus_alpha_offsets = builder.dyn_array(round.openings.len());
410409
let all_zero_slices = builder.dyn_array(round.openings.len());
411-
let opening_heights = builder.dyn_array(round.openings.len());
412410
let dimensions = builder.dyn_array(round.openings.len());
413411

414412
iter_zip!(
@@ -420,7 +418,6 @@ pub(crate) fn batch_verifier_query_phase<C: Config>(
420418
high_values_buffer,
421419
minus_alpha_offsets,
422420
all_zero_slices,
423-
opening_heights,
424421
dimensions,
425422
)
426423
.for_each(|ptr_vec, builder| {
@@ -455,10 +452,6 @@ pub(crate) fn batch_verifier_query_phase<C: Config>(
455452

456453
let all_zero_slice = all_zeros.slice(builder, 0, width);
457454
builder.iter_ptr_set(&all_zero_slices, ptr_vec[6], all_zero_slice);
458-
459-
let num_var = opening.num_var;
460-
let height: Var<C::N> = builder.eval(num_var + Usize::from(get_rate_log() - 1));
461-
builder.iter_ptr_set(&opening_heights, ptr_vec[7], height);
462455
});
463456

464457
// TODO: ensure that perm is indeed a permutation of 0, ..., opened_values.len()-1
@@ -468,7 +461,7 @@ pub(crate) fn batch_verifier_query_phase<C: Config>(
468461
builder
469462
.range(0, round.openings.len())
470463
.for_each(|j_vec, builder| {
471-
let height_j = builder.get(&opening_heights, j_vec[0]);
464+
let height_j = builder.get(&log2_heights, j_vec[0]);
472465
let permuted_j = builder.get(&round.perm, j_vec[0]);
473466
// let permuted_j = j;
474467
builder.set_value(&dimensions, permuted_j, height_j);
@@ -483,7 +476,6 @@ pub(crate) fn batch_verifier_query_phase<C: Config>(
483476
log2_heights,
484477
minus_alpha_offsets,
485478
all_zero_slices,
486-
opening_heights,
487479
dimensions,
488480
};
489481
builder.iter_ptr_set(&rounds_context, ptr_vec[1], round_context);

0 commit comments

Comments
 (0)