Crash when you use the text tool on this one svg

[ericrosenbaum]

Expected Behavior

Paint editor should not crash when you use the text tool

Actual Behavior

When you're editing this one costume, and use the text tool, the paint editor crashes.

Steps to Reproduce

• load this svg as a costume (it's a costume from this project)
• add text to it using the text tool
• click away to deselect
• crash!

Operating System and Browser

I've seen the crash on:
Mac Chrome
Windows Chrome
Windows Edge

[apple502j]

Fun fact: on Firefox 76 (Windows), it does not crash, but it kinda breaks:

Old Editor

New Editor

1. after that the grid disappears
2. the canvas no longer recognizes mouse click event properly

[apple502j]

It seems like https://github.com/LLK/paper.js/blob/develop/src/basic/Matrix.js#L653 is doing the thing:

a, b, c, d, tx, ty, det are all 0, so the if won't run (det is falsy), and it returns null.

The question is, what's causing this?

[apple502j]

I can "fix" this by adding

            if (point === null) {
                return attrs;
            }

to paper.js svg/SvgExport..js L34.

However, the exported SVG had something concerning:

<image x="NaN" y="NaN" width="28" height="52" xlink:href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABwAAAA0CAYAAACZ8ljPAAAATUlEQVR42u3YsREAEBQDUO5sYQ37T2ANc1BRa3zNywLvkjJl9DlTYEoKzgFry/kltJf81xAIBAKBQCAQCAQCgUAgEAgEAu/AqGc4vOEC+/sMLwkZFMwAAAAtdEVYdFNvZnR3YXJlAGJ5LmJsb29kZHkuY3J5cHRvLmltYWdlLlBORzI0RW5jb2RlcqgGf+4AAAAASUVORK5CYII=" id="ID0.4243265725672245" fill="#000000" stroke="none" stroke-width="1" stroke-linecap="butt"/>