Skip to content

Commit 2b93beb

Browse files
authored
Merge pull request #13 from LLK/revert-12-errorify-warnings
Revert "feat(reat,es6,node,base,deps): Move all warnings to errors"
2 parents 5f0c51f + 5d9f43a commit 2b93beb

File tree

5 files changed

+28
-23
lines changed

5 files changed

+28
-23
lines changed

es6.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ module.exports = {
99
'no-confusing-arrow': [2],
1010
'no-useless-computed-key': [2],
1111
'no-useless-constructor': [2],
12-
'no-var': [2],
12+
'no-var': [1],
1313
'prefer-arrow-callback': [2],
14-
'prefer-const': [2, {destructuring: 'all'}],
14+
'prefer-const': [1, {destructuring: 'all'}],
1515
'prefer-template': [2],
1616
'rest-spread-spacing': [2, 'never'],
1717
'template-curly-spacing': [2, 'never']

index.js

+18-13
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,19 @@ module.exports = {
2323
}],
2424

2525
// Best practices
26-
'array-callback-return': [2],
27-
'block-scoped-var': [2],
26+
'array-callback-return': [1],
27+
'block-scoped-var': [1],
2828
'curly': [2, 'multi-line'],
2929
'dot-location': [2, 'property'],
3030
'dot-notation': [2],
3131
'eqeqeq': [2],
3232
'no-alert': [2],
3333
'no-div-regex': [2],
34-
'no-else-return': [2],
34+
'no-else-return': [1],
3535
'no-eq-null': [2],
3636
'no-eval': [2],
3737
'no-extend-native': [2],
38-
'no-extra-bind': [2],
38+
'no-extra-bind': [1],
3939
'no-global-assign': [2],
4040
'no-implied-eval': [2],
4141
'no-invalid-this': [2],
@@ -44,17 +44,22 @@ module.exports = {
4444
'no-loop-func': [2],
4545
'no-multi-spaces': [2],
4646
'no-multi-str': [2],
47-
'no-new': [2],
47+
'no-new': [1],
4848
'no-proto': [2],
49+
'no-restricted-properties': [1, {
50+
object: 'lodash',
51+
property: 'defaults',
52+
message: 'Please use Object.assign'
53+
}],
4954
'no-return-assign': [2],
5055
'no-script-url': [2],
5156
'no-self-compare': [2],
52-
'no-sequences': [2],
57+
'no-sequences': [1],
5358
'no-throw-literal': [2],
54-
'no-unmodified-loop-condition': [2],
59+
'no-unmodified-loop-condition': [1],
5560
'no-unused-expressions': [2],
5661
'no-useless-call': [2],
57-
'no-useless-concat': [2],
62+
'no-useless-concat': [1],
5863
'no-useless-escape': [2],
5964
'no-warning-comments': [1, {
6065
location: 'anywhere'
@@ -70,7 +75,7 @@ module.exports = {
7075
'no-shadow': [2],
7176
'no-undefined': [2],
7277
'no-use-before-define': [2],
73-
78+
7479
// Strict
7580
'strict': [2, 'never'],
7681

@@ -106,14 +111,14 @@ module.exports = {
106111
}],
107112
'new-parens': [2],
108113
'newline-per-chained-call': [2],
109-
'no-lonely-if': [2],
110-
'no-mixed-operators': [2],
114+
'no-lonely-if': [1],
115+
'no-mixed-operators': [1],
111116
'no-multiple-empty-lines': [2, {
112117
max: 2,
113118
maxBOF: 0,
114119
maxEOF: 0
115120
}],
116-
'no-negated-condition': [2],
121+
'no-negated-condition': [1],
117122
'no-tabs': [2],
118123
'no-trailing-spaces': [2, {skipBlankLines: true}],
119124
'no-unneeded-ternary': [2],
@@ -128,7 +133,7 @@ module.exports = {
128133
allowTemplateLiterals: true,
129134
avoidEscape: true
130135
}],
131-
'require-jsdoc': [2],
136+
'require-jsdoc': [1],
132137
'semi': [2, 'always'],
133138
'semi-spacing': [2],
134139
'space-before-function-paren': [2, 'always'],

node.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module.exports = {
22
rules: {
33
// Node/CommonJS
44
'global-require': [2],
5-
'handle-callback-err': [2],
5+
'handle-callback-err': [1],
66
'no-mixed-requires': [2],
77
'no-new-require': [2],
88
'no-path-concat': [2]

package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,16 @@
2626
"scratch"
2727
],
2828
"optionalDependencies": {
29-
"eslint-plugin-react": "7.x"
29+
"eslint-plugin-react": "6.x"
3030
},
3131
"peerDependencies": {
3232
"babel-eslint": "7.x",
33-
"eslint": "4.x"
33+
"eslint": "3.x"
3434
},
3535
"devDependencies": {
36-
"babel-eslint": "^7.2.3",
36+
"babel-eslint": "^7.0.0",
3737
"cz-conventional-changelog": "1.2.0",
38-
"eslint": "^4.4.1",
38+
"eslint": "^3.8.1",
3939
"semantic-release": "^4.3.5"
4040
},
4141
"config": {

react.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ module.exports = {
1616
}],
1717
'react/no-render-return-value': [2],
1818
'react/no-set-state': [0],
19-
'react/no-string-refs': [2],
19+
'react/no-string-refs': [1],
2020
'react/no-unescaped-entities': [2],
2121
'react/no-unknown-property': [2],
2222
'react/no-unused-prop-types': [2],
2323
'react/prefer-es6-class': [2],
24-
'react/prefer-stateless-function': [2],
24+
'react/prefer-stateless-function': [1],
2525
'react/prop-types': [2],
2626
'react/react-in-jsx-scope': [2],
2727
'react/require-optimization': [0],
@@ -43,7 +43,7 @@ module.exports = {
4343
'react/jsx-indent-props': [2],
4444
'react/jsx-key': [2],
4545
'react/jsx-max-props-per-line': [2, {maximum: 1}],
46-
'react/jsx-no-bind': [2, {
46+
'react/jsx-no-bind': [1, {
4747
ignoreRefs: true
4848
}],
4949
'react/jsx-no-comment-textnodes': [2],

0 commit comments

Comments
 (0)