Skip to content

Conversation

@yaswanth1701
Copy link
Contributor

Test on: Ubuntu 22 and gazebo 11
This is a follow-up PR to #27 and solves #25 . Now instead of calculating error/metric in gazebo api a separate python script has been added. This facilitates simulator-independent metric calculation functionality. The script currently processes the logged data in CSV format for calculations.

Steps to run post-processing with benchmark

cd build
cmake ..
make 
make test

yaswanth1701 and others added 30 commits May 20, 2024 01:40
Signed-off-by: gonna_yaswanth <[email protected]>
Signed-off-by: gonna_yaswanth <[email protected]>
Signed-off-by: gonna_yaswanth <[email protected]>
Signed-off-by: gonna_yaswanth <[email protected]>
Signed-off-by: gonna_yaswanth <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
yaswanth1701 and others added 9 commits August 1, 2024 09:35
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
@yaswanth1701 yaswanth1701 requested a review from scpeters as a code owner August 4, 2024 05:16
@yaswanth1701 yaswanth1701 changed the title Post processing Added post processing for boxes benchmark Aug 7, 2024
Copy link
Owner

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, just a few minor comments

also it could be helpful to distinguish more clearly between the two types of csv files we generate:

  • the csv converted from mcap for each test case / instance / run
  • the csv of postprocessed data for the entire set of tests

T0 = 0.5*self.m*v0.dot(v0) + 0.5*self.w0.dot(self.I.dot(self.w0))
V0 = - self.m*self.gravity.dot(self.pos0)
self.E0 = T0 + V0
self.E0_mag = np.linalg.norm(self.E0)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the energy is a scalar, so E0_mag looks like a duplicate of E0 to me (whereas L0 is a Vector3, so L0_mag makes sense)

@yaswanth1701
Copy link
Contributor Author

yaswanth1701 commented Aug 25, 2024

also it could be helpful to distinguish more clearly between the two types of csv files we generate:

  • the csv converted from mcap for each test case / instance / run
  • the csv of postprocessed data for the entire set of tests

Hi Steve sorry for asking again, but are these suggestions regarding the project report or post-processing script? If it is for post-processing, should I consider adding comments and changing the variable naming?

Signed-off-by: yaswanth1701 <[email protected]>
@scpeters
Copy link
Owner

also it could be helpful to distinguish more clearly between the two types of csv files we generate:

  • the csv converted from mcap for each test case / instance / run
  • the csv of postprocessed data for the entire set of tests

Hi Steve sorry for asking again, but are these suggestions regarding the project report or post-processing script? If it is for post-processing, should I consider adding comments and changing the variable naming?

I think it can be for both, but more importantly for now is the report

@yaswanth1701
Copy link
Contributor Author

also it could be helpful to distinguish more clearly between the two types of csv files we generate:

  • the csv converted from mcap for each test case / instance / run
  • the csv of postprocessed data for the entire set of tests

Hi Steve sorry for asking again, but are these suggestions regarding the project report or post-processing script? If it is for post-processing, should I consider adding comments and changing the variable naming?

I think it can be for both, but more importantly for now is the report

Got it! Thanks

@yaswanth1701
Copy link
Contributor Author

Hi Steve I just updated the project report can you take a look ?https://gist.github.com/yaswanth1701/d9ac86875046d827d65f6f48963a13c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants