-
Notifications
You must be signed in to change notification settings - Fork 5
Added post processing for boxes benchmark #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: gonna_yaswanth <[email protected]>
Signed-off-by: gonna_yaswanth <[email protected]>
Signed-off-by: gonna_yaswanth <[email protected]>
Signed-off-by: gonna_yaswanth <[email protected]>
Signed-off-by: gonna_yaswanth <[email protected]>
Signed-off-by: gonna_yaswanth <[email protected]>
Signed-off-by: gonna_yaswanth <[email protected]>
Signed-off-by: gonna_yaswanth <[email protected]>
Signed-off-by: gonna_yaswanth <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
Signed-off-by: yaswanth1701 <[email protected]>
scpeters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good, just a few minor comments
also it could be helpful to distinguish more clearly between the two types of csv files we generate:
- the
csvconverted frommcapfor each test case / instance / run - the
csvof postprocessed data for the entire set of tests
| T0 = 0.5*self.m*v0.dot(v0) + 0.5*self.w0.dot(self.I.dot(self.w0)) | ||
| V0 = - self.m*self.gravity.dot(self.pos0) | ||
| self.E0 = T0 + V0 | ||
| self.E0_mag = np.linalg.norm(self.E0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the energy is a scalar, so E0_mag looks like a duplicate of E0 to me (whereas L0 is a Vector3, so L0_mag makes sense)
Co-authored-by: Steve Peters <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
Hi Steve sorry for asking again, but are these suggestions regarding the project report or post-processing script? If it is for post-processing, should I consider adding comments and changing the variable naming? |
Signed-off-by: yaswanth1701 <[email protected]>
I think it can be for both, but more importantly for now is the report |
Got it! Thanks |
|
Hi Steve I just updated the project report can you take a look ?https://gist.github.com/yaswanth1701/d9ac86875046d827d65f6f48963a13c7 |
Test on: Ubuntu 22 and gazebo 11
This is a follow-up PR to #27 and solves #25 . Now instead of calculating error/metric in gazebo api a separate python script has been added. This facilitates simulator-independent metric calculation functionality. The script currently processes the logged data in CSV format for calculations.
Steps to run post-processing with benchmark