Make favorites cache refresh optional before placing bid

[scottmconway]

I would like to see the option to either 1) add a flag to the favorite's note or 2) add a config option to turn OFF a forcible refresh of the favorites cache before placing a bid.

The main use case here would be that the favorites cache refresh request to ShopGoodwill can sometimes hang (i.e. return a "104: Connection reset by peer" error), which can result in failing to post a bid (especially with a smaller bid_snipe_time_delta value).

To be honest, I haven't scrutinized the exceptions thrown in the log to confirm this is the cause, but that's what I suspect can at least sometimes be the cause when my bids fail to POST. The actual bid POST request can also seem to hang, but the option to remove the forced favorites refresh does seem like a way to reduce the chance of a bid failing to POST in time.

Originally posted by @david-noa in #4

[scottmconway]

I think the second option should be pursued, as I see no reason why you'd want this behavior to be item-specific. As of now a hard-coded cache time of 5 seconds is used when refreshing the cache in place_bid.

The easiest change would be to have this value refer to bid_sniper's config while defaulting to 5 if a value is not provided.

[david-noa]

Regarding the failed bids, I tried placing a bid manually and it looks like I'm getting this warning erroneously - perhaps a bug with ShopGoodwill or perhaps my account has been flagged in some way? In either case, it doesn't look like this error is being caught/logged from what I can tell.

I'll try and replicate this week and check the response payload with Dev tools.

UPDATE:
Looks like this warning was a fluke? bid_sniper.py seems to be working again /shrug