Skip to content

Commit

Permalink
Fix Linux font install for Python 3
Browse files Browse the repository at this point in the history
install-chromeos-fonts.py references python, which is not guaranteed to
be installed (at least not on Googler machines). Instead, python2 and
python3 are guaranteed available (in depot_tools if not elsewhere).

This leads to this error message:

    Installing Chrome OS fonts.
    /usr/bin/env: ‘python’: No such file or directory
    ERROR: The installation of the Chrome OS default fonts failed.

The remainder of the error message is misleading (in this context) and
has a spelling error which this also fixes.

Change-Id: Ie05a95d654a51448240f3910dd4bb54a32f54336
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3539216
Reviewed-by: Thomas Anderson <[email protected]>
Commit-Queue: Bruce Dawson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#983457}
  • Loading branch information
randomascii authored and Chromium LUCI CQ committed Mar 21, 2022
1 parent 428150f commit b26115f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion build/install-build-deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,7 @@ if [ "$do_inst_chromeos_fonts" != "0" ]; then
echo "This is expected if your repo is installed on a remote file system."
fi
echo "It is recommended to install your repo on a local file system."
echo "You can skip the installation of the Chrome OS default founts with"
echo "You can skip the installation of the Chrome OS default fonts with"
echo "the command line option: --no-chromeos-fonts."
exit 1
fi
Expand Down
2 changes: 1 addition & 1 deletion build/linux/install-chromeos-fonts.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env python
#!/usr/bin/env python3
# Copyright 2013 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
Expand Down

0 comments on commit b26115f

Please sign in to comment.