Skip to content

Commit

Permalink
[COIL] Change chromium code search type links to use main rather than…
Browse files Browse the repository at this point in the history
… master for components

    See this doc: go/chromium-coil-change for more info
    BUG=1210385

Change-Id: I9a04252f74e3a698744310d2d86516d174ea38b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2902866
Reviewed-by: Colin Blundell <[email protected]>
Commit-Queue: John Palmer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#885850}
  • Loading branch information
John Palmer authored and Chromium LUCI CQ committed May 24, 2021
1 parent c75306b commit a13109c
Show file tree
Hide file tree
Showing 23 changed files with 41 additions and 41 deletions.
2 changes: 1 addition & 1 deletion components/autofill_assistant/browser/action_value.proto
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,6 @@ message KeyEvent {
optional string key = 4;
// Editing commands to send with the key event (e.g., 'selectAll').
// The list of commands can be found here:
// https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/editing/commands/editor_command_names.h
// https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/editing/commands/editor_command_names.h
repeated string command = 5;
}
2 changes: 1 addition & 1 deletion components/cast_channel/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ If the test has no seed corpus, omit the last parameter:
% ./out/libfuzzer/$TEST_NAME ${TEST_NAME}_corpus
```

For more details, refer to https://chromium.googlesource.com/chromium/src/testing/libfuzzer/+/refs/heads/master/getting_started.md
For more details, refer to https://chromium.googlesource.com/chromium/src/testing/libfuzzer/+/refs/heads/main/getting_started.md
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ public abstract ExperimentalUrlRequest.Builder newUrlRequestBuilder(
* Once logging has stopped {@link #stopNetLog}, the data will be written
* to netlog.json in {@code dirPath}. If logging is interrupted, you can
* stitch the files found in .inprogress subdirectory manually using:
* https://chromium.googlesource.com/chromium/src/+/master/net/tools/stitch_net_log_files.py.
* https://chromium.googlesource.com/chromium/src/+/main/net/tools/stitch_net_log_files.py.
* The log can be viewed using a Chrome browser navigated to chrome://net-internals/#import.
* @param dirPath the directory where the netlog.json file will be created. dirPath must
* already exist. NetLog files must not exist in the directory. If actively
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ protected NetworkException(String message, Throwable cause) {
* Returns a Cronet internal error code. This may provide more specific error
* diagnosis than {@link #getErrorCode}, but the constant values are not exposed to Java and
* may change over time. See
* <a href=https://chromium.googlesource.com/chromium/src/+/master/net/base/net_error_list.h>
* <a href=https://chromium.googlesource.com/chromium/src/+/main/net/base/net_error_list.h>
* here</a> for the lastest list of values.
*
* @return Cronet internal error code.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class NetworkExceptionImpl extends NetworkException {
* @param message explanation of failure.
* @param errorCode error code, one of {@link #ERROR_HOSTNAME_NOT_RESOLVED ERROR_*}.
* @param cronetInternalErrorCode Cronet internal error code, one of
* <a href=https://chromium.googlesource.com/chromium/src/+/master/net/base/net_error_list.h>
* <a href=https://chromium.googlesource.com/chromium/src/+/main/net/base/net_error_list.h>
* these</a>.
*/
public NetworkExceptionImpl(String message, int errorCode, int cronetInternalErrorCode) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class QuicExceptionImpl extends QuicException {
*
* @param message explanation of failure.
* @param netErrorCode Error code from
* <a href=https://chromium.googlesource.com/chromium/src/+/master/net/base/net_error_list.h>
* <a href=https://chromium.googlesource.com/chromium/src/+/main/net/base/net_error_list.h>
* this list</a>.
* @param quicDetailedErrorCode Detailed <a href="https://www.chromium.org/quic">QUIC</a> error
* code from <a
Expand Down
2 changes: 1 addition & 1 deletion components/cronet/ios/docs/BUILD.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Get source and dependencies
### source
- Install depot_tools per https://chromium.googlesource.com/chromium/src/+/master/docs/ios/build_instructions.md
- Install depot_tools per https://chromium.googlesource.com/chromium/src/+/main/docs/ios/build_instructions.md
- Make directory for the chromium source, and then fetch:
```
~ $ mkdir chromium && cd chromium
Expand Down
2 changes: 1 addition & 1 deletion components/cronet/native/cronet.idl
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ struct Error {
* Cronet internal error code. This may provide more specific error
* diagnosis than |error_code|, but the constant values may change over time.
* See
* <a href=https://chromium.googlesource.com/chromium/src/+/master/net/base/net_error_list.h>
* <a href=https://chromium.googlesource.com/chromium/src/+/main/net/base/net_error_list.h>
* here</a> for the lastest list of values.
*/
int32 internal_error_code = 0;
Expand Down
2 changes: 1 addition & 1 deletion components/crx_file/crx3.proto
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ message CrxFileHeader {
// A verified contents file containing signatures over the archive contents.
// The verified contents are encoded in UTF-8 and then GZIP-compressed.
// Consult
// https://source.chromium.org/chromium/chromium/src/+/master:extensions/browser/verified_contents.h
// https://source.chromium.org/chromium/chromium/src/+/main:extensions/browser/verified_contents.h
// for information about the verified contents format.
optional bytes verified_contents = 4;

Expand Down
6 changes: 3 additions & 3 deletions components/exo/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ https://wayland-book.com/.
Current clients of Exo include:

* ARC++ (Android apps on Chrome OS)
* [Chromecast](https://chromium.googlesource.com/chromium/src/+/master/chromecast/README.md)
* [Chromecast](https://chromium.googlesource.com/chromium/src/+/main/chromecast/README.md)
* Crostini (Linux apps on Chrome OS)
* [Lacros](https://chromium.googlesource.com/chromium/src/+/master/docs/lacros.md)
* [Lacros](https://chromium.googlesource.com/chromium/src/+/main/docs/lacros.md)
* PluginVM

In addition to the core Wayland protocol, Exo supports a number of protocol
extensions. Some are third-party; see
[//third_party/wayland-protocols/README.chromium](https://chromium.googlesource.com/chromium/src/+/master/third_party/wayland-protocols/README.chromium).
[//third_party/wayland-protocols/README.chromium](https://chromium.googlesource.com/chromium/src/+/main/third_party/wayland-protocols/README.chromium).
Others are Chromium-specific.

A few noteworthy extensions (this list is not at all exhaustive):
Expand Down
2 changes: 1 addition & 1 deletion components/external_intents/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ implementations of the above-mentioned interfaces:
navigations: https://bugs.chromium.org/p/chromium/issues/detail?id=1087434.
- Chrome and WebLayer have different mechanisms for getting the last user
interaction time, as documented here:
https://source.chromium.org/chromium/chromium/src/+/master:weblayer/browser/java/org/chromium/weblayer_private/InterceptNavigationDelegateClientImpl.java;l=71?q=InterceptNavigationDelegateClientImpl&ss=chromium&originalUrl=https:%2F%2Fcs.chromium.org%2F
https://source.chromium.org/chromium/chromium/src/+/main:weblayer/browser/java/org/chromium/weblayer_private/InterceptNavigationDelegateClientImpl.java;l=71?q=InterceptNavigationDelegateClientImpl&ss=chromium&originalUrl=https:%2F%2Fcs.chromium.org%2F

There are almost certainly further smaller differences, but those are the major
highlights.
Expand Down
2 changes: 1 addition & 1 deletion components/feature_engagement/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ ninja -C out/Debug components_unittests ;
When adding new test suites, also remember to add the suite to the filter file:
`//components/feature_engagement/components_unittests.filter`.

[field-trial-testing-configuration]: https://chromium.googlesource.com/chromium/src/+/master/testing/variations/README.md
[field-trial-testing-configuration]: https://chromium.googlesource.com/chromium/src/+/main/testing/variations/README.md

## IPH Analysis Guideline

Expand Down
2 changes: 1 addition & 1 deletion components/nacl/loader/nacl_helper_linux.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ enum NaClZygoteIPCCommand {
// The next set of constants define global Linux file descriptors.
// For communications between NaCl loader and browser.
// See also content/common/zygote_main_linux.cc and
// https://chromium.googlesource.com/chromium/src/+/master/docs/linux/zygote.md
// https://chromium.googlesource.com/chromium/src/+/main/docs/linux/zygote.md

// For communications between NaCl loader and zygote.
#define kNaClZygoteDescriptor 3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
void NaClMainPlatformDelegate::EnableSandbox(
const content::MainFunctionParams& parameters) {
// The setuid sandbox is started in the zygote process: zygote_main_linux.cc
// https://chromium.googlesource.com/chromium/src/+/master/docs/linux/suid_sandbox.md
// https://chromium.googlesource.com/chromium/src/+/main/docs/linux/suid_sandbox.md
//
// The seccomp sandbox is started in the renderer.
// http://code.google.com/p/seccompsandbox/
Expand Down
2 changes: 1 addition & 1 deletion components/net_log/resources/net_export.html
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ <h2>Log file written</h2>
logging once the issue has reproduced.</li>
<li>Existing log files can be shrunk using
<a
href="https://chromium.googlesource.com/chromium/src/+/master/net/tools/truncate_net_log.py"
href="https://chromium.googlesource.com/chromium/src/+/main/net/tools/truncate_net_log.py"
target="_blank">
net/tools/truncate_net_log.py</a>.</li>
</ul>
Expand Down
4 changes: 2 additions & 2 deletions components/onc/docs/onc_spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -2181,7 +2181,7 @@ setting selected as the effective setting.
## Mojo format

Chrome provides a mojo API for ONC properties:
https://source.chromium.org/chromium/chromium/src/+/master:chromeos/services/network_config/public/mojom/cros_network_config.mojom
https://source.chromium.org/chromium/chromium/src/+/main:chromeos/services/network_config/public/mojom/cros_network_config.mojom

The mojo API uses a simplified structure for managed properties based on the
following assumptions:
Expand All @@ -2196,7 +2196,7 @@ In this simplified format, a descriptive enum is used to describe the effective
policy source and whether it is enforced or recommended.

The conversion code can be found in cros_network_config.cc:GetManagedDictionary
https://source.chromium.org/chromium/chromium/src/+/master:chromeos/services/network_config/cros_network_config.cc
https://source.chromium.org/chromium/chromium/src/+/main:chromeos/services/network_config/cros_network_config.cc

```
enum PolicySource {
Expand Down
10 changes: 5 additions & 5 deletions components/paint_preview/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ discrepencies;

### Compositing

To maintain the [Rule Of 2](https://chromium.googlesource.com/chromium/src/+/master/docs/security/rule-of-2.md)
To maintain the [Rule Of 2](https://chromium.googlesource.com/chromium/src/+/main/docs/security/rule-of-2.md)
compositing takes place in a sandboxed utility process. The Skia Pictures are
loaded into the compositor and from those pictures bitmaps can be generated. A
caller may elect to request the contents of the frame be turned into a single
Expand All @@ -76,14 +76,14 @@ for it.
## Usage

Capture step is intended to be completed via
[PaintPreviewBaseService::CapturePaintPreview()](https://source.chromium.org/chromium/chromium/src/+/master:components/paint_preview/browser/paint_preview_base_service.h;bpv=1;bpt=1;l=127)
[PaintPreviewBaseService::CapturePaintPreview()](https://source.chromium.org/chromium/chromium/src/+/main:components/paint_preview/browser/paint_preview_base_service.h;bpv=1;bpt=1;l=127)
, although
[PaintPreviewClient](https://source.chromium.org/chromium/chromium/src/+/master:components/paint_preview/browser/paint_preview_client.h;bpv=1;bpt=1;l=36)
[PaintPreviewClient](https://source.chromium.org/chromium/chromium/src/+/main:components/paint_preview/browser/paint_preview_client.h;bpv=1;bpt=1;l=36)
can be used directly if preferred.

Compositing should be started using [StartCompositorService()](https://source.chromium.org/chromium/chromium/src/+/master:components/paint_preview/browser/compositor_utils.h;bpv=1;bpt=1;l=16).
Compositing should be started using [StartCompositorService()](https://source.chromium.org/chromium/chromium/src/+/main:components/paint_preview/browser/compositor_utils.h;bpv=1;bpt=1;l=16).
This should be followed by using the PaintPreviewCompositorService to create a
[PaintPreviewCompositorClient](https://source.chromium.org/chromium/chromium/src/+/master:components/paint_preview/public/paint_preview_compositor_client.h;bpv=1;bpt=1;l=24)
[PaintPreviewCompositorClient](https://source.chromium.org/chromium/chromium/src/+/main:components/paint_preview/public/paint_preview_compositor_client.h;bpv=1;bpt=1;l=24)
from which compositing can be controlled.

See the `player/` subdirectory for more details on playback.
Expand Down
22 changes: 11 additions & 11 deletions components/paint_preview/player/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,26 @@

The player displays a paint preview that has been previously recorded.
Currently, the player is only fully implemented for Android. However, there
are a few platform-independent base classes ([`PlayerCompositorDelegate`](https://source.chromium.org/chromium/chromium/src/+/master:/components/paint_preview/player/player_compositor_delegate.cc)
, [`CompositorStatus`](https://source.chromium.org/chromium/chromium/src/+/master:/components/paint_preview/player/compositor_status.h)
, [`BitmapRequest `](https://source.chromium.org/chromium/chromium/src/+/master:/components/paint_preview/player/bitmap_request.cc)
are a few platform-independent base classes ([`PlayerCompositorDelegate`](https://source.chromium.org/chromium/chromium/src/+/main:/components/paint_preview/player/player_compositor_delegate.cc)
, [`CompositorStatus`](https://source.chromium.org/chromium/chromium/src/+/main:/components/paint_preview/player/compositor_status.h)
, [`BitmapRequest `](https://source.chromium.org/chromium/chromium/src/+/main:/components/paint_preview/player/bitmap_request.cc)
) than can be used to extend the playback support for other platforms.

`PlayerCompositorDelegate` uses the [StartCompositorService](https://source.chromium.org/chromium/chromium/src/+/master:components/paint_preview/browser/compositor_utils.h;bpv=1;bpt=1;l=16?q=StartCompositorService&ss=chromium&gsn=StartCompositorService&gs=kythe%3A%2F%2Fchromium.googlesource.com%2Fchromium%2Fsrc%3Flang%3Dc%252B%252B%3Fpath%3Dsrc%2Fcomponents%2Fpaint_preview%2Fbrowser%2Fcompositor_utils.h%23E_S97S1y6_-ukZj8vR6XZUzOTYFPwOkwR0LybvqxVWg)
`PlayerCompositorDelegate` uses the [StartCompositorService](https://source.chromium.org/chromium/chromium/src/+/main:components/paint_preview/browser/compositor_utils.h;bpv=1;bpt=1;l=16?q=StartCompositorService&ss=chromium&gsn=StartCompositorService&gs=kythe%3A%2F%2Fchromium.googlesource.com%2Fchromium%2Fsrc%3Flang%3Dc%252B%252B%3Fpath%3Dsrc%2Fcomponents%2Fpaint_preview%2Fbrowser%2Fcompositor_utils.h%23E_S97S1y6_-ukZj8vR6XZUzOTYFPwOkwR0LybvqxVWg)
API. Alternatively, playback support for other platforms can be provided by
using `StartCompositorService` directly for more flexibility.

The remainder of this doc describes the Android-specific implementation.

## TL;DR

Want to use the player? Construct a [`PlayerManager`](https://source.chromium.org/chromium/chromium/src/+/master:/components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/PlayerManager.java)
and use [`PlayerManager#getView`](https://source.chromium.org/chromium/chromium/src/+/master:components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/PlayerManager.java;drc=c62b2799aeef847ccb9fbd5d1fc3e19e2938df9a;l=240)
Want to use the player? Construct a [`PlayerManager`](https://source.chromium.org/chromium/chromium/src/+/main:/components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/PlayerManager.java)
and use [`PlayerManager#getView`](https://source.chromium.org/chromium/chromium/src/+/main:components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/PlayerManager.java;drc=c62b2799aeef847ccb9fbd5d1fc3e19e2938df9a;l=240)
to display it.

## Design

As mentioned in the main [`README`](https://source.chromium.org/chromium/chromium/src/+/master:/components/paint_preview/README.md)
As mentioned in the main [`README`](https://source.chromium.org/chromium/chromium/src/+/main:/components/paint_preview/README.md)
, a paint preview can have multiple frames in a nested structure.
Consequently, the player is desinged in a nested structure as well, to
facilitate the display of mulitple nested frames.
Expand All @@ -35,15 +35,15 @@ classes. These are responsible for displaying a single frame.

### Important classes

* [`PlayerManager`](https://source.chromium.org/chromium/chromium/src/+/master:/components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/PlayerManager.java):
* [`PlayerManager`](https://source.chromium.org/chromium/chromium/src/+/main:/components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/PlayerManager.java):
Entry point for using the player. When created it initializes the compositor
and populates a hierarchy of player frames based on the paint preview.
* [`PlayerCompositorDelegateImpl`](https://source.chromium.org/chromium/chromium/src/+/master:/components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/PlayerCompositorDelegateImpl.java)
* [`PlayerCompositorDelegateImpl`](https://source.chromium.org/chromium/chromium/src/+/main:/components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/PlayerCompositorDelegateImpl.java)
: Communicates with the paint preview compositor. It requests bitmaps from the
comopsitor and provides them to palyer frames.
* [`PlayerFrameMediator`](https://source.chromium.org/chromium/chromium/src/+/master:/components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/frame/PlayerFrameMediator.java)
* [`PlayerFrameMediator`](https://source.chromium.org/chromium/chromium/src/+/main:/components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/frame/PlayerFrameMediator.java)
: Handles the business logic for a single frame in the player, i.e.
maintaining a viewport, updating its sub-frame visibilities, requesting
bitmaps from the compositor delegate, etc.
* [`PlayerFrameView`](https://source.chromium.org/chromium/chromium/src/+/master:/components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/frame/PlayerFrameView.java)
* [`PlayerFrameView`](https://source.chromium.org/chromium/chromium/src/+/main:/components/paint_preview/player/android/java/src/org/chromium/components/paintpreview/player/frame/PlayerFrameView.java)
: The View that displays a single frame.
2 changes: 1 addition & 1 deletion components/password_manager/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ Here is a summary of the core responsibilities of the classes and interfaces:

This is actually a collection of two interfaces named
`*::PasswordManagerDriver`. The first one ([`mojom::PasswordManagerDriver`])
is a [mojo](https://chromium.googlesource.com/chromium/src/+/master/mojo/)
is a [mojo](https://chromium.googlesource.com/chromium/src/+/main/mojo/)
interface that allows renderers to talk to the browser. The second one
([`password_manager::PasswordManagerDriver`]) allows the browser to talk to
renderers.
Expand Down
2 changes: 1 addition & 1 deletion components/sync/protocol/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ General guidelines:

Some specific guidelines on top of the general ones above, or just things that often come up:
* Enum entries should be in ALL_CAPS (different from C++!), and for new code, the first entry should be a `FOO_UNSPECIFIED = 0` one.
* Proto changes also require corresponding changes in [proto_visitors.h](https://source.chromium.org/chromium/chromium/src/+/master:components/sync/protocol/proto_visitors.h) and (where appropriate) in [proto_enum_conversions.h/cc](https://source.chromium.org/chromium/chromium/src/+/master:components/sync/protocol/proto_enum_conversions.cc).
* Proto changes also require corresponding changes in [proto_visitors.h](https://source.chromium.org/chromium/chromium/src/+/main:components/sync/protocol/proto_visitors.h) and (where appropriate) in [proto_enum_conversions.h/cc](https://source.chromium.org/chromium/chromium/src/+/main:components/sync/protocol/proto_enum_conversions.cc).
* Backwards compatibility: In general, all changes must be fully backwards-compatible - consider that a single user might be running different versions of the browser simultaneously! Also note that Sync supports clients up to a few years old, so deprecating/removing an existing field is typically a multi-year process.
* As one special case, **renaming** a field **within a specifics message** is generally safe (unless there are special server-side integrations that depend on the name). However, **never** rename fields anywhere outside of specifics.
* Deprecating fields:
Expand Down
Loading

0 comments on commit a13109c

Please sign in to comment.