We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
According to the JVM specification Throwables should not be caught, because they can include runtime Errors that are not recoverable https://docs.oracle.com/javase/specs/jls/se7/html/jls-11.html. Slingshot currently casts ExceptionInfo to Throwable https://github.com/scgilardi/slingshot/blob/release/src/slingshot/support.clj#L37, which forces me to catch Throwables including severe unrecoverable runtime errors. It should be sufficient to put a cast to ^Exception there. I can open a PR if this sounds reasonable.
Throwable
Error
ExceptionInfo
^Exception
The text was updated successfully, but these errors were encountered:
No branches or pull requests
According to the JVM specification
Throwable
s should not be caught, because they can include runtimeError
s that are not recoverable https://docs.oracle.com/javase/specs/jls/se7/html/jls-11.html. Slingshot currently castsExceptionInfo
toThrowable
https://github.com/scgilardi/slingshot/blob/release/src/slingshot/support.clj#L37, which forces me to catchThrowable
s including severe unrecoverable runtime errors. It should be sufficient to put a cast to^Exception
there. I can open a PR if this sounds reasonable.The text was updated successfully, but these errors were encountered: