Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.12.2 introduces breaking changes in ex-data behavior #57

Open
vedang opened this issue Jan 20, 2022 · 0 comments
Open

Release 0.12.2 introduces breaking changes in ex-data behavior #57

vedang opened this issue Jan 20, 2022 · 0 comments

Comments

@vedang
Copy link

vedang commented Jan 20, 2022

Objects are no longer wrapped in a :object post e11c268, so any caller who parses the exception and runs ex-data on it gets an unexpected return value.

IMHO, the change itself is fine, but it should be clearly mentioned in the release notes / changelog as such so that upgrading to the latest version becomes simpler. Also, ideally this should be a Major version or at least a Minor version upgrade instead of a patch update.

I added a comment on the commit as well, but not sure how notifications on comments works. So opening an issue to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant