Skip to content

Allow onMessage to be set and processed #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 30, 2019
Merged

Allow onMessage to be set and processed #22

merged 3 commits into from
Aug 30, 2019

Conversation

@jamespearson
Copy link
Contributor

@jamespearson jamespearson commented Jan 10, 2019

(Similar issue is in #16 , but their fix doesn't work).

Currently, if you set onMessage, the spread of this.props on the webview overwrites the call to _onMessage , rendering the component useless.

To fix I have:

  • reorder the properties on the webview, to ensure onMessage is not overwritten
  • ensure there is a default onMessage function (no-op)
  • Added a call to the passed onMessage once _onMessage has dealt with the height.

@jamespearson jamespearson mentioned this pull request Jan 10, 2019
Open
@scazzy scazzy merged commit 28758c6 into scazzy:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamespearson @scazzy