Skip to content

Commit ae06c50

Browse files
authored
Explicitly request node v16.14.2 + npm v8.5.0 (GoogleChrome#7632)
* Use node v16.14.2 * Update Cloud Build, too
1 parent a1e34df commit ae06c50

File tree

5 files changed

+15
-13
lines changed

5 files changed

+15
-13
lines changed

.cloudbuild/deploy.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,19 @@
22

33
timeout: 2700s # set build timeout to 45 mins
44
steps:
5-
- name: node:16
5+
- name: node:16.14.2
66
id: 'Install dependencies'
77
entrypoint: npm
88
args: ['ci', '--production']
99

10-
- name: node:16
10+
- name: node:16.14.2
1111
id: 'Generate .env file'
1212
entrypoint: npm
1313
args: ['run', 'cloud-secrets']
1414
env:
1515
- 'PROJECT_ID=$PROJECT_ID'
1616

17-
- name: node:16
17+
- name: node:16.14.2
1818
id: 'Build site'
1919
entrypoint: npm
2020
args: ['run', 'build']
@@ -26,7 +26,7 @@ steps:
2626
id: 'Deploy site to Firebase'
2727
args: ['deploy']
2828

29-
- name: node:16
29+
- name: node:16.14.2
3030
id: 'Algolia index site'
3131
entrypoint: npm
3232
args: ['run', 'algolia']

.cloudbuild/version-check.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# This Cloud Build task can kick off our actual deploy if the hash has changed.
22

33
steps:
4-
- name: node:16
4+
- name: node:16.14.2
55
id: 'Install dependencies'
66
entrypoint: npm
77
args: ['ci', '--production']
88

9-
- name: node:16
9+
- name: node:16.14.2
1010
id: 'Verify and maybe kick off build for new version'
1111
entrypoint: npm
1212
args: ['run', 'version-check']

.github/workflows/presubmit-workflow.yml

+7-5
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ jobs:
99
isPresubmit: ${{ steps.presubmit.outputs.isPresubmit }}
1010
steps:
1111
- name: Checkout
12-
uses: actions/checkout@v2
13-
with:
14-
fetch-depth: 1
12+
uses: actions/checkout@v3
1513

1614
- name: Install dependencies
1715
run: npm ci --prefix .github/actions/presubmit
@@ -31,9 +29,13 @@ jobs:
3129
NODE_OPTIONS: --max_old_space_size=4096
3230
steps:
3331
- name: Checkout
34-
uses: actions/checkout@v2
32+
uses: actions/checkout@v3
33+
34+
- name: Setup node
35+
uses: actions/setup-node@v3
3536
with:
36-
fetch-depth: 1
37+
node-version: 'v16.14.2'
38+
cache: 'npm'
3739

3840
- name: Install dependencies
3941
run: npm ci

.nvmrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v16.14.0
1+
v16.14.2

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,6 @@
172172
"not ie <= 11"
173173
],
174174
"volta": {
175-
"node": "16.14.0"
175+
"node": "16.14.2"
176176
}
177177
}

0 commit comments

Comments
 (0)