Skip to content

Commit 5a096df

Browse files
fix(deploy): properly format NODE_OPTIONS (GoogleChrome#6262)
1 parent 4350889 commit 5a096df

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

.cloudbuild/deploy.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ steps:
2020
args: ['run', 'build']
2121
env:
2222
- 'ELEVENTY_ENV=prod'
23-
- 'NODE_OPTIONS=--max_old_space_size=4096`
23+
- "NODE_OPTIONS='--max_old_space_size=4096'"
2424

2525
- name: 'gcr.io/$PROJECT_ID/firebase'
2626
id: 'Deploy site to Firebase'

version-check.js

+10-6
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,14 @@ const getDeployedVersion = () => {
6666
return;
6767
}
6868

69-
// This just waits for the build to be kicked off, not for its completion (it
70-
// returns a LROperation).
71-
await client.runBuildTrigger({
72-
projectId: process.env.PROJECT_ID,
73-
triggerId: deployTriggerId,
74-
});
69+
try {
70+
// This just waits for the build to be kicked off, not for its completion (it
71+
// returns a LROperation).
72+
await client.runBuildTrigger({
73+
projectId: process.env.PROJECT_ID,
74+
triggerId: deployTriggerId,
75+
});
76+
} catch (e) {
77+
errors.report(e);
78+
}
7579
})();

0 commit comments

Comments
 (0)