Mark the callback as optional

williamlardier · williamlardier · commit 8200a2e61c5b · 2024-12-10T17:07:48.000+01:00
Without callback, it is impossible to unit-test the backbeat routes, as we run async code and do not yet support promises. Issue: CLDSRV-591
diff --git a/lib/routes/routeBackbeat.js b/lib/routes/routeBackbeat.js
@@ -1310,7 +1310,8 @@ const indexingSchema = joi.array().items(indexEntrySchema).min(1);
 
 function respondToRequest(err, response, log, callback) {
     responseJSONBody(err, null, response, log);
-    return callback(err);
+    // The callback is optional, as it is only used for testing purposes
+    return callback?.(err);
 }
 
 function routeIndexingAPIs(request, response, userInfo, log, callback) {

Original file line number	Diff line number	Diff line change
`@@ -1310,7 +1310,8 @@ const indexingSchema = joi.array().items(indexEntrySchema).min(1);`
`1310`	`1310`
`1311`	`1311`	`function respondToRequest(err, response, log, callback) {`
`1312`	`1312`	`responseJSONBody(err, null, response, log);`
`1313`		`- return callback(err);`
	`1313`	`+ // The callback is optional, as it is only used for testing purposes`
	`1314`	`+ return callback?.(err);`
`1314`	`1315`	`}`
`1315`	`1316`
`1316`	`1317`	`function routeIndexingAPIs(request, response, userInfo, log, callback) {`