added error test cases

Author: Diego Ardila

nucleus/dataset_item.py

@@ -21,7 +21,6 @@ class DatasetItem:
     metadata: Optional[dict] = None
 
     def __post_init__(self):
-        self.image_url = self.image_location
         self.local = is_local_path(self.image_location)
 
     @classmethod
@@ -37,11 +36,11 @@ def from_json(cls, payload: dict):
         )
 
     def local_file_exists(self):
-        return os.path.isfile(self.image_url)
+        return os.path.isfile(self.image_location)
 
     def to_payload(self) -> dict:
         payload = {
-            IMAGE_URL_KEY: self.image_url,
+            IMAGE_URL_KEY: self.image_location,
             METADATA_KEY: self.metadata or {},
         }
         if self.reference_id:

nucleus/job.py

@@ -20,19 +20,20 @@ def status(self) -> Dict[str, str]:
     def errors(self) -> List[str]:
         return self.client.make_request(
             payload={},
-            route=f"job/${self.id}/errors",
+            route=f"job/{self.id}/errors",
             requests_command=requests.get,
         )
 
     def sleep_until_complete(self, verbose_std_out=True):
         while 1:
             time.sleep(1)
             status = self.status()
+            if verbose_std_out:
+                print(status)
             if status["status"] == "Running":
-                if verbose_std_out:
-                    print(status)
                 continue
             break
+
         final_status = status
         if final_status["status"] == "Errored":
             raise JobError(final_status, self)

tests/test_dataset.py

@@ -1,3 +1,4 @@
+from nucleus.job import JobError
 import pytest
 import os
 
@@ -155,6 +156,46 @@ def test_dataset_append_async(dataset: Dataset):
     }
 
 
+def test_dataset_append_async_with_local_path(dataset: Dataset):
+    ds_items = make_dataset_items()
+    ds_items[
+        0
+    ].image_location = "/a/fake/local/path/you/can/tell/is/local/but/is/fake"
+    with pytest.raises(ValueError):
+        dataset.append(ds_items, asynchronous=True)
+
+
+def test_dataset_append_async_with_1_bad_url(dataset: Dataset):
+    ds_items = make_dataset_items()
+    ds_items[0].image_location = "https://looks.ok.but.is.not.accessible"
+    job = dataset.append(ds_items, asynchronous=True)
+    with pytest.raises(JobError):
+        job.sleep_until_complete()
+    assert job.status() == {
+        "job_id": f"{job.id}",
+        "status": "Errored",
+        "message": {
+            "final_error": (
+                "One or more of the images you attempted to upload did not process"
+                " correctly. Please see the status for an overview and the errors for "
+                "more detailed messages."
+            ),
+            "image_upload_step": {"errored": 1, "pending": 0, "completed": 4},
+            "ingest_to_reupload_queue": {
+                "epoch": 1,
+                "total": 5,
+                "datasetId": f"{dataset.id}",
+                "processed": 5,
+            },
+            "started_image_processing": f"Dataset: {dataset.id}, Job: {job.id}",
+        },
+    }
+    assert job.errors() == [
+        "One or more of the images you attempted to upload did not process correctly. Please see the status for an overview and the errors for more detailed messages.",
+        'Failure when processing the image "https://looks.ok.but.is.not.accessible": {}',
+    ]
+
+
 def test_dataset_list_autotags(CLIENT, dataset):
     # Creation
     # List of Autotags should be empty