Skip to content

do not patch the implicit scope of scala.Unit in Scala.js #24405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2025
Merged

do not patch the implicit scope of scala.Unit in Scala.js #24405

merged 1 commit into from
Nov 12, 2025

Conversation

@hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Nov 12, 2025 •
edited
Loading

Previously, we used to patch the implicit scope of scala.Unit to include unitOrOps.
In this PR, we remove that patch and instead define the implicit conversion in the source code.
Note that now the source code of scala.Unit has been copied in library-js and that it calls the old method since the constructor of js.UndefOrOps is package private to js.

This PR is part of having less magic in the compiler when it is not needed (or not needed anymore).

@hamzaremmal hamzaremmal marked this pull request as ready for review November 12, 2025 21:00
@hamzaremmal hamzaremmal requested a review from a team as a code owner November 12, 2025 21:00
@hamzaremmal hamzaremmal requested a review from sjrd November 12, 2025 21:00
@hamzaremmal hamzaremmal added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Nov 12, 2025
@hamzaremmal hamzaremmal merged commit aaf3dc4 into scala:main Nov 12, 2025
53 checks passed
@hamzaremmal hamzaremmal deleted the unit-conversion-sjs branch November 12, 2025 22:44
@WojciechMazur WojciechMazur added this to the 3.8.0 milestone Nov 13, 2025
@WojciechMazur WojciechMazur mentioned this pull request Nov 13, 2025
Merged
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Nov 13, 2025
WojciechMazur added a commit that referenced this pull request Nov 13, 2025
@WojciechMazur
Backport "do not patch the implicit scope of scala.Unit in Scala.js…
f1719cf 
…" to 3.8.0 (#24411)

Backports #24405 to the 3.8.0-RC1.

PR submitted by the release tooling.
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjrd sjrd sjrd approved these changes

Assignees

@sjrd sjrd

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hamzaremmal @sjrd @WojciechMazur