Skip to content

Do not assume left is non-null if another branch is null in splitLast #24325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 3, 2025
Merged

Do not assume left is non-null if another branch is null in splitLast #24325

merged 3 commits into from
Nov 3, 2025
+21 −2

Conversation

@noti0na1
Copy link
Member

@noti0na1 noti0na1 commented Nov 3, 2025

Fix NPE in #24177

@noti0na1 noti0na1 requested a review from a team as a code owner November 3, 2025 14:09
@hamzaremmal hamzaremmal merged commit b83b3d9 into scala:main Nov 3, 2025
53 checks passed
@hamzaremmal hamzaremmal deleted the fix-splitLast-nn branch November 3, 2025 23:33
@noti0na1
Copy link
Member Author

noti0na1 commented Nov 3, 2025

Hi @WojciechMazur, can you backport this to 3.8.0 branch? thanks

@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Nov 12, 2025
@WojciechMazur WojciechMazur added this to the 3.8.0 milestone Nov 12, 2025
@WojciechMazur WojciechMazur mentioned this pull request Nov 12, 2025
Merged
WojciechMazur added a commit that referenced this pull request Nov 12, 2025
@WojciechMazur
Backport "Do not assume left is non-null if another branch is null in…
6934c68 
… splitLast" to 3.8.0 (#24402)

Backports #24325 to the 3.8.0-RC1.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hamzaremmal hamzaremmal hamzaremmal approved these changes

Assignees

@hamzaremmal hamzaremmal

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@noti0na1 @hamzaremmal @WojciechMazur