Merge pull request #483 from scala/backport-lts-3.3-23462

Backport "Exclude named parameters inlay hints for java defined" to 3.3 LTS

Author: tgodzik

presentation-compiler/src/main/dotty/tools/pc/PcInlayHintsProvider.scala

@@ -434,7 +434,7 @@ object Parameters:
   def unapply(tree: Tree)(using params: InlayHintsParams, ctx: Context): Option[(Boolean, List[(Name, SourcePosition, Boolean)])] = 
     def shouldSkipFun(fun: Tree)(using Context): Boolean = 
       fun match
-        case sel: Select => isForComprehensionMethod(sel) || sel.symbol.name == nme.unapply
+        case sel: Select => isForComprehensionMethod(sel) || sel.symbol.name == nme.unapply || sel.symbol.is(Flags.JavaDefined)
         case _ => false
 
     def isInfixFun(fun: Tree, args: List[Tree])(using Context): Boolean = 

presentation-compiler/test/dotty/tools/pc/tests/inlayHints/InlayHintsSuite.scala

@@ -1227,4 +1227,20 @@ class InlayHintsSuite extends BaseInlayHintsSuite {
          |}
          |""".stripMargin
     )
+
+   @Test def `java-method-call` =
+    check(
+     """|object Main {
+        |  val str = "hello"
+        |  val sub = str.substring(1, 3)
+        |  val replaced = str.replace('l', 'x')
+        |}
+        |""".stripMargin,
+     """|object Main {
+        |  val str/*: String<<java/lang/String#>>*/ = "hello"
+        |  val sub/*: String<<java/lang/String#>>*/ = str.substring(1, 3)
+        |  val replaced/*: String<<java/lang/String#>>*/ = str.replace('l', 'x')
+        |}
+        |""".stripMargin
+    )
 }