New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks with SHA longer than 8 #231

Open

alexander-bunkenburg-chartboost opened this issue Jun 23, 2022 · 0 comments

alexander-bunkenburg-chartboost commented Jun 23, 2022 •

edited

Loading

The "git describe --abbrev=8" returns a SHA with length 8 or more if necessary.

I hit a case where 9 was necessary: "v1.0.20220610+60-97fed8831".

Parsing the SHA in GitDescribeOutput.parse assumes it's exactly 8 characters long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment