timeframe_n_last_days is not supported yet

[aspiers]

No parameters are ever currently passed to the constructor of a Timeframe subclass. In particular, the config setting timeframe_n_last_days is totally ignored. I'm not sure why it was ever included in rapport.conf?

[saschpe]

I didn't manage to finish this so far because I wasn't sure yet how to expose this to the CLI. Similarly, I wasn't sure how the config file would ideally look like. I.e. the simple approach:

[timeframe]
default=...
timeframe_n_last_days=...
...

or more like this:

[timeframe]
default=...

[timeframe:n_last_days]
days=7

The latter is similar to how plugins are currently expressed in the config and seems more extensible to me. But it could also be overhead since it's dubious if other timeframes (than those already present) will be necessary. So I would like to get your opinion on that and simply implement the missing bits in rapport/cli.py.

[aspiers]

I prefer the latter unless it's significantly more complex to implement. I think a timeframe allowing an arbitrary date range is worth while, and in that instance you would want

[timeframe:custom]
start=...
end=...

[saschpe]

And this would simply map to the Timeframe base class. I'll do it this way then

[aspiers]

Now I see:

    if args.start:
        timeframe = rapport.timeframe.init("generic", start=args.start, end=args.end)

but no corresponding entry in _TIMEFRAME_CATALOG. Am I missing something?

[aspiers]

Also the sample rapport.conf needs updating.