AppVeyor builds failing

[mnadareski]

Describe the bug
Currently, AppVeyor immediately fails to build the project because there are two solution files that are included in the repo. To fix this, I think the only thing that needs to happen is that either the Windows or Linux solution file has to have the path provided as the default and it should behave correctly.

[saramibreak]

I don't know how to fix it, so I left it alone. I would appreciate it if someone could fix it.

[mnadareski]

The only way that someone can help fix it would be if the AppVeyor config was included, at least partially, as a file in the repo. I think you currently have it setup so that the entire configuration lives in AppVeyor which is the default behavior.

[mnadareski]

Here is a link to the docs for appveyor.yml: https://www.appveyor.com/docs/appveyor-yml/

I think there might be a way to export your current configuration as one of these YML files so it can just be committed. Otherwise, it would need to be built up with your specific needs for automatic builds.

[saramibreak]

Some settings were fixed.

Build started
git clone -q --branch=test https://github.com/saramibreak/DiscImageCreator.git C:\projects\discimagecreator
git checkout -qf 51[2](https://ci.appveyor.com/project/saramibreak/discimagecreator#L2)6ba5ae028fd589aaeaf56c7878d4e295e81c1
msbuild "C:\projects\discimagecreator\DiscImageCreator.sln" /verbosity:minimal /logger:"C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll"
MSBuild version 17.12.12+1cce77968 for .NET Framework
C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v150\Platforms\x64\PlatformToolsets\v141_xp\Toolset.targets([3](https://ci.appveyor.com/project/saramibreak/discimagecreator#L3)9,5): warning MSB8051: Support for targeting Windows XP is deprecated and will not be present in future releases of Visual Studio. Please see https://go.microsoft.com/fwlink/?linkid=2023588 for more information. [C:\projects\discimagecreator\DiscImageCreator\DiscImageCreator.vcxproj]
  CreateBuildDateTime.h
  stdafx.cpp
c:\projects\discimagecreator\discimagecreator\stdafx.h([5](https://ci.appveyor.com/project/saramibreak/discimagecreator#L5)0): fatal error C1083: Cannot open include file: 'ntddcdrm.h': No such file or directory [C:\projects\discimagecreator\DiscImageCreator\DiscImageCreator.vcxproj]
Command exited with code 1

ntddcdrm.h is Windows Driver Kit file, there is not in the repository. How do I build files that is not in the repository?

[mnadareski]

According to their docs, the only versions of the WDK that are installed in the image by default are WDK 8 (available with Visual Studio 2013) and WDK 10 (available with Visual Studio 2015, 2017, 2019).

I forgot about the dependence on the older WDK, specifically WDK 7, that's needed for DiscImageCreator on Windows. It seems like the only way to get around this would either to update to WDK 8 (which officially supports only Windows 7 and above) or find another auto-building solution. I can look into if Jenkins or GitHub Actions can support this, though it's starting to get old enough that it may not.

[mnadareski]

Okay, unfortunately Jenkins relies entirely on what you have on your machine and GitHub Actions only goes back to Windows Server 2019 and they only include WDK 10 versions from that onward. Automatic Windows builds may not work properly on the common platforms due to the atypical combination of build requirements.