Merge pull request #1774 from sanger/Y26-015-emq-logging-visibility

Y26-015 - EMQ Logging visibility

Author: BenTopping

app/messages/emq/publishing_job.rb

@@ -44,6 +44,13 @@ def publish(objects, message_config, schema_key) # rubocop:disable Metrics/AbcSi
       if message_builder_config_obj.nil?
         Rails.logger.error('Message builder configuration not found for ' \
                            "schema key: #{schema_key} and version: #{version}")
+        # Ensure we also notify via email as this could indicate a systemic issue
+        # and it is important we are made aware of it as it could affect volume tracking data
+        ExceptionNotifier.notify_exception(
+          StandardError.new(
+            "Message builder config not found for schema key: #{schema_key} and version: #{version}"
+          )
+        )
         return
       end
       message_builder_class = message_builder_config_obj.message_class.to_s.constantize
@@ -75,6 +82,9 @@ def publish(objects, message_config, schema_key) # rubocop:disable Metrics/AbcSi
         # This is to prevent the job from failing and to allow the job to continue
         # These logs can be monitored through Kibana
         Rails.logger.error("Failed to publish message to EMQ: #{e.message}")
+        # Ensure we also notify via email as this could indicate a systemic issue
+        # and it is important we are made aware of it as it could affect volume tracking data
+        ExceptionNotifier.notify_exception(e)
       end
     end
 

spec/messages/emq/publishing_job_spec.rb

@@ -90,12 +90,14 @@
     bunny_config[:amqp][:schemas][:subjects][:volume_tracking][:version] = 3
     expect(emq_sender_mock).not_to receive(:send_message)
     expect(Rails.logger).to receive(:error).with('Message builder configuration not found for schema key: volume_tracking and version: 3')
+    expect(ExceptionNotifier).to receive(:notify_exception).with(StandardError.new('Message builder config not found for schema key: volume_tracking and version: 3'))
     publishing_job.publish(aliquot, Pipelines.pacbio, 'volume_tracking')
   end
 
   it 'logs error message when the EMQ is down' do
     allow(emq_sender_mock).to receive(:send_message).and_raise(StandardError)
     expect(Rails.logger).to receive(:error).with('Failed to publish message to EMQ: StandardError')
+    expect(ExceptionNotifier).to receive(:notify_exception).with(instance_of(StandardError))
     publishing_job.publish(aliquot, Pipelines.pacbio, 'volume_tracking')
   end
 end