Skip to content

Conversation

@Nitinyadav237
Copy link
Contributor

@Nitinyadav237 Nitinyadav237 commented Dec 1, 2025

fix #643


Important

Fixes special character display in i18n text by replacing HTML entity with apostrophe in settings.json and resources.d.ts.

  • Fixes:
    • Replaces HTML entity ' with ' in walletAddAccountDeriveDescription in settings.json and resources.d.ts.
  • Files Affected:
    • settings.json: Corrects text for "Derive an account from the Wallet's mnemonic".
    • resources.d.ts: Updates interface Resources to reflect the same text correction.

This description was created by Ellipsis for 73c3ffd. You can customize this summary. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 73c3ffd in 44 seconds. Click for details.
  • Reviewed 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/i18n/locales/en/settings.json:64
  • Draft comment:
    Good fix: The HTML entity has been replaced with a literal apostrophe. Verify that this change is consistent with other locales.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. packages/i18n/src/resources.d.ts:128
  • Draft comment:
    For consistency, consider either escaping the single quote in a single-quoted string (e.g. 'Wallet's mnemonic') or using double quotes uniformly, as other entries use single quotes.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_udXs9VoZWGSG4J7A

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@tobeycodes tobeycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nitinyadav237 Thanks for creating this pull request. We appreciate the contribution. It looks like this has already been solved in another PR created earlier and additionally fixes some other special characters elsewhere.

@tobeycodes tobeycodes closed this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Special characters in text

2 participants