Add tests for helpers in solana-client package

[beeman]

Why

We don't have enough tests in our solana-client packages which allows us to ship regressions

What

Add tests for the helper functions so we're sure they behave as expected over time.

Deliverables

Unit tests for the helper functions that make sense to unit test.

To do

• Figure out which of the files below need a unit test
• If they don't, write down why not (need e2e test, there is no logic to test, they already have a test, etc)
• Create small PR's to test them individually.

Context

These are the current files.

• constants.ts
• create-and-send-sol-transaction.ts
• create-and-send-spl-transaction.ts
• create-sol-transfer-transaction.ts test: add create-sol-transfer-transaction unit test #385 test: improve create-sol-transfer-transaction test coverage #465
• create-solana-client.ts
• create-spl-transfer-transaction.ts test: unit test for create-spl-transfer-transaction #406
• get-account-info.ts test: unit tests for get-account-info #489
• get-activity.ts
• get-balance.ts
• get-explorer-url.ts
• get-solana-network-from-genesis-hash.ts
• get-token-accounts-for-program-id.ts
• get-token-accounts.ts
• is-valid-signature.ts
• lamports-to-sol.ts
• max-available-sol-amount.ts
• request-airdrop.ts
• sol-to-lamports.ts
• solana-client.ts
• solana-network.ts
• spl-token-create-token-account.ts
• spl-token-create-token-mint.ts
• unix-timestamp-to-date.ts
• utils.ts

[tobeycodes]

@beeman I created a PR for what I would call integration tests which will use surfpool or solana-test-validator #389. I do think there is still value to unit test some of these functions that call the RPC but the integrations tests will allow us to test the integration between our code and the RPC.

I can also create another PR for e2e tests which from my understanding of them would be creating tests end to end which would start at the web app, and actually clicking the buttons to trigger all the underlying code.

[rishavmehra]

@beeman can you please assign me this issue?

[beeman]

@rishavmehra I don't think assigning the whole issue is a good idea because of the scope. I'd rather have you pick one of them (for example create-spl-transfer-transaction.ts ) and start with that following the example in #385 .

[ABFX15]

hey @beeman can I work on this?

[beeman]

hey @beeman can I work on this?

Hey there @ABFX15. Considering the amount of work to be done here, please pick one of them and start with the examples done by others. My suggestion is to start with a simple one to get your feed wet.

Please be sure to go over our contributing guide and join our Discord if you have any questions! 🙏