Skip to content

Commit 6c0a4b1

Browse files
cryptomilkanoopcs9
authored andcommitted
nsswitch: Do not leak memory in wbinfo_pam_logon() of wbinfo
We need to always free the memory, not only if verbose mode is wanted. Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x7f4df73215a3 in calloc (/lib64/libasan.so.8+0x1215a3) (BuildId: 388ee9ac193f74c177c6f52988d2d0dab110de41) #1 0x7f4df712833f in wbcAllocateMemory ../../nsswitch/libwbclient/wbclient.c:216 #2 0x7f4df712d996 in wbc_create_logon_info ../../nsswitch/libwbclient/wbc_pam.c:326 #3 0x7f4df712d996 in wbcCtxLogonUser ../../nsswitch/libwbclient/wbc_pam.c:1288 #4 0x7f4df712dda5 in wbcLogonUser ../../nsswitch/libwbclient/wbc_pam.c:1311 #5 0x00000021c014 in wbinfo_pam_logon ../../nsswitch/wbinfo.c:1995 #6 0x00000021c014 in main ../../nsswitch/wbinfo.c:3209 #7 0x7f4df422b2fa in __libc_start_call_main (/lib64/libc.so.6+0x2b2fa) (BuildId: 8523b213e7586a93ab00f6dd476418b1e521e62c) #8 0x7ffc9aee3e03 ([stack]+0x20e03) Signed-off-by: Andreas Schneider <[email protected]> Reviewed-by: Anoop C S <[email protected]> Autobuild-User(master): Anoop C S <[email protected]> Autobuild-Date(master): Thu Oct 30 09:11:26 UTC 2025 on atb-devel-224
1 parent 3f82b85 commit 6c0a4b1

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

nsswitch/wbinfo.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2037,10 +2037,9 @@ static bool wbinfo_pam_logon(char *username, bool verbose)
20372037
d_printf(" %s", buf);
20382038
}
20392039
d_printf("\n");
2040-
2041-
wbcFreeMemory(info);
2042-
info = NULL;
20432040
}
2041+
wbcFreeMemory(info);
2042+
info = NULL;
20442043

20452044
wbcFreeMemory(params.blobs);
20462045

0 commit comments

Comments
 (0)