Skip to content

Commit 0d9f230

Browse files
committed
official release
1 parent d4e0091 commit 0d9f230

File tree

5 files changed

+12
-10
lines changed

5 files changed

+12
-10
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ See [contributing guide](.github/CONTRIBUTING.md)
9494

9595
| Date | Version | Description |
9696
| ----------- | ------- | ----------- |
97+
| 2017-01-22 | v1.0.0 | Official release |
9798
| 2017-01-22 | v0.0.2 | Initial release |
9899

99100
<a name="license"></a>

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "simple-web-notification",
3-
"version": "0.0.2",
3+
"version": "1.0.0",
44
"description": "Web Notifications made easy.",
55
"authors": [
66
"Sagie Gur-Ari <[email protected]>"

docs/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
| Date | Version | Description |
22
| ----------- | ------- | ----------- |
3+
| 2017-01-22 | v1.0.0 | Official release |
34
| 2017-01-22 | v0.0.2 | Initial release |

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "simple-web-notification",
3-
"version": "0.0.2",
3+
"version": "1.0.0",
44
"description": "Web Notifications made easy.",
55
"author": {
66
"name": "Sagie Gur-Ari",

web-notification.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
}(this, function initWebNotification(NotifyLib) {
4343
'use strict';
4444

45-
var service = {};
45+
var webNotification = {};
4646

4747
/**
4848
* The internal Notification library used by this library.
@@ -51,7 +51,7 @@
5151
* @alias webNotification.lib
5252
* @private
5353
*/
54-
service.lib = NotifyLib;
54+
webNotification.lib = NotifyLib;
5555

5656
/**
5757
* True to enable automatic requesting of permissions if needed.
@@ -61,10 +61,10 @@
6161
* @alias webNotification.allowRequest
6262
* @public
6363
*/
64-
service.allowRequest = true; //true to enable automatic requesting of permissions if needed
64+
webNotification.allowRequest = true; //true to enable automatic requesting of permissions if needed
6565

6666
/*eslint-disable func-name-matching*/
67-
Object.defineProperty(service, 'permissionGranted', {
67+
Object.defineProperty(webNotification, 'permissionGranted', {
6868
/**
6969
* Returns the permission granted value.
7070
*
@@ -116,7 +116,7 @@
116116
* @returns {Boolean} True if allowed to show web notifications
117117
*/
118118
var isEnabled = function () {
119-
return service.permissionGranted;
119+
return webNotification.permissionGranted;
120120
};
121121

122122
/**
@@ -246,7 +246,7 @@
246246
* });
247247
* ```
248248
*/
249-
service.showNotification = function () {
249+
webNotification.showNotification = function () {
250250
//convert to array to enable modifications
251251
var argumentsArray = Array.prototype.slice.call(arguments, 0);
252252

@@ -262,7 +262,7 @@
262262
if (isEnabled()) {
263263
hideNotification = createAndDisplayNotification(title, options);
264264
callback(null, hideNotification);
265-
} else if (service.allowRequest) {
265+
} else if (webNotification.allowRequest) {
266266
NotifyLib.requestPermission(function onRequestDone() {
267267
if (isEnabled()) {
268268
hideNotification = createAndDisplayNotification(title, options);
@@ -277,5 +277,5 @@
277277
}
278278
};
279279

280-
return service;
280+
return webNotification;
281281
}));

0 commit comments

Comments
 (0)