Merge remote-tracking branch 'origin/master' into express-5-8529

Author: haraldschilly

src/packages/frontend/account/dark-mode.ts

@@ -10,9 +10,6 @@ import { AccountStore } from "./store";
 
 export const DARK_MODE_KEYS = ["brightness", "contrast", "sepia"] as const;
 
-// Icon unicode character for dark mode toggle (◑ - circle with right half black)
-export const DARK_MODE_ICON = 0x25d1;
-
 type Config = Record<(typeof DARK_MODE_KEYS)[number], number>;
 
 export const DARK_MODE_MINS: Config = {

src/packages/frontend/account/editor-settings/font-size.tsx

@@ -5,6 +5,7 @@
 
 import { InputNumber } from "antd";
 import { LabeledRow } from "@cocalc/frontend/components";
+import { DEFAULT_FONT_SIZE } from "@cocalc/util/consts/ui";
 import { useIntl } from "react-intl";
 
 interface Props {
@@ -24,7 +25,7 @@ export function EditorSettingsFontSize(props: Props) {
       className="cc-account-prefs-font-size"
     >
       <InputNumber
-        onChange={(n) => props.on_change("font_size", n ?? 14)}
+        onChange={(n) => props.on_change("font_size", n ?? DEFAULT_FONT_SIZE)}
         min={5}
         max={32}
         value={props.font_size}

src/packages/frontend/account/other-settings.tsx

@@ -4,10 +4,10 @@
  */
 
 import { Button, Card, Slider } from "antd";
-import { debounce } from "lodash";
 import { Map } from "immutable";
+import { debounce } from "lodash";
 import { useMemo } from "react";
-import { defineMessages, FormattedMessage, useIntl } from "react-intl";
+import { FormattedMessage, defineMessages, useIntl } from "react-intl";
 
 import { Checkbox, Panel } from "@cocalc/frontend/antd-bootstrap";
 import { Rendered, redux, useTypedRedux } from "@cocalc/frontend/app-framework";
@@ -41,15 +41,15 @@ import {
 import { NewFilenameFamilies } from "@cocalc/frontend/project/utils";
 import track from "@cocalc/frontend/user-tracking";
 import { webapp_client } from "@cocalc/frontend/webapp-client";
+import { DARK_MODE_ICON } from "@cocalc/util/consts/ui";
 import { DEFAULT_NEW_FILENAMES, NEW_FILENAMES } from "@cocalc/util/db-schema";
+import { DARK_MODE_DEFAULTS } from "@cocalc/util/db-schema/accounts";
 import { OTHER_SETTINGS_REPLY_ENGLISH_KEY } from "@cocalc/util/i18n/const";
 import {
-  DARK_MODE_ICON,
   DARK_MODE_KEYS,
   DARK_MODE_MINS,
   get_dark_mode_config,
 } from "./dark-mode";
-import { DARK_MODE_DEFAULTS } from "@cocalc/util/db-schema/accounts";
 import { I18NSelector, I18N_MESSAGE, I18N_TITLE } from "./i18n-selector";
 import Messages from "./messages";
 import Tours from "./tours";

src/packages/frontend/cspell.json

@@ -89,7 +89,10 @@
     "immutablejs",
     "ipynb",
     "isabs",
+    "isactive",
     "isdir",
+    "isopen",
+    "issymlink",
     "kernelspec",
     "LLM",
     "LLMs",

src/packages/frontend/editors/slate/editable-markdown.tsx

@@ -28,6 +28,7 @@ import { EditorFunctions } from "@cocalc/frontend/editors/markdown-input/multimo
 import { SAVE_DEBOUNCE_MS } from "@cocalc/frontend/frame-editors/code-editor/const";
 import { useFrameContext } from "@cocalc/frontend/frame-editors/frame-tree/frame-context";
 import { Path } from "@cocalc/frontend/frame-editors/frame-tree/path";
+import { DEFAULT_FONT_SIZE } from "@cocalc/util/consts/ui";
 import { EditorState } from "@cocalc/frontend/frame-editors/frame-tree/types";
 import { markdown_to_html } from "@cocalc/frontend/markdown";
 import Fragment, { FragmentId } from "@cocalc/frontend/misc/fragment-id";
@@ -171,7 +172,7 @@ export const EditableMarkdown: React.FC<Props> = React.memo((props: Props) => {
   const isMountedRef = useIsMountedRef();
   const id = id0 ?? "";
   const actions = actions0 ?? {};
-  const font_size = font_size0 ?? desc?.get("font_size") ?? 14; // so possible to use without specifying this.  TODO: should be from account settings
+  const font_size = font_size0 ?? desc?.get("font_size") ?? DEFAULT_FONT_SIZE; // so possible to use without specifying this.  TODO: should be from account settings
   const [change, setChange] = useState<number>(0);
 
   const editor = useMemo(() => {

src/packages/frontend/frame-editors/frame-tree/commands/generic-commands.tsx

@@ -10,7 +10,6 @@ import { debounce } from "lodash";
 import { useEffect, useRef } from "react";
 import { defineMessage, IntlShape, useIntl } from "react-intl";
 
-import { DARK_MODE_ICON } from "@cocalc/frontend/account/dark-mode";
 import { set_account_table } from "@cocalc/frontend/account/util";
 import { redux } from "@cocalc/frontend/app-framework";
 import { Icon } from "@cocalc/frontend/components";
@@ -30,6 +29,7 @@ import { isSupportedExtension } from "@cocalc/frontend/project/page/home-page/ai
 import { AI_GENERATE_DOC_TAG } from "@cocalc/frontend/project/page/home-page/ai-generate-utils";
 import openSupportTab from "@cocalc/frontend/support/open";
 import userTracking from "@cocalc/frontend/user-tracking";
+import { DARK_MODE_ICON } from "@cocalc/util/consts/ui";
 import { filename_extension } from "@cocalc/util/misc";
 import { addCommands } from "./commands";
 import { SEARCH_COMMANDS } from "./const";

src/packages/frontend/frame-editors/latex-editor/output-control-build.tsx

@@ -12,9 +12,8 @@ import type { MenuProps } from "antd";
 import { Dropdown } from "antd";
 import { useIntl } from "react-intl";
 
-import { Button as BSButton } from "@cocalc/frontend/antd-bootstrap";
-import { DARK_MODE_ICON } from "@cocalc/frontend/account/dark-mode";
 import { set_account_table } from "@cocalc/frontend/account/util";
+import { Button as BSButton } from "@cocalc/frontend/antd-bootstrap";
 import { useRedux, useTypedRedux } from "@cocalc/frontend/app-framework";
 import { Icon } from "@cocalc/frontend/components";
 import { COMMANDS } from "@cocalc/frontend/frame-editors/frame-tree/commands";
@@ -24,6 +23,7 @@ import {
   BUILD_ON_SAVE_LABEL,
 } from "@cocalc/frontend/frame-editors/frame-tree/commands/generic-commands";
 import { editor, IntlMessage } from "@cocalc/frontend/i18n";
+import { DARK_MODE_ICON } from "@cocalc/util/consts/ui";
 
 import { Actions } from "./actions";
 

src/packages/frontend/frame-editors/latex-editor/output-files.tsx

@@ -63,7 +63,7 @@ export function OutputFiles({
       path: filePath,
       displayPath,
       isMain: false,
-      summary: fileSummaries[filePath] ?? "Loading...",
+      summary: fileSummaries[filePath] ?? "Summary not available...",
     };
   });
 

src/packages/frontend/frame-editors/latex-editor/output.tsx

@@ -40,6 +40,7 @@ import {
 import { EditorState } from "@cocalc/frontend/frame-editors/frame-tree/types";
 import { project_api } from "@cocalc/frontend/frame-editors/generic/client";
 import { editor, labels } from "@cocalc/frontend/i18n";
+import { DEFAULT_FONT_SIZE } from "@cocalc/util/consts/ui";
 
 import { TITLE_BAR_BORDER } from "../frame-tree/style";
 import { Actions } from "./actions";
@@ -253,8 +254,8 @@ export function Output(props: OutputProps) {
   // Handle zoom changes from pinch-to-zoom or wheel gestures
   const handleZoomChange = useCallback(
     (data: Data) => {
-      // Convert fontSize to zoom scale (fontSize 14 = 1.0 zoom)
-      const newZoom = data.fontSize / 14;
+      // Convert fontSize to zoom scale (DEFAULT_FONT_SIZE = 1.0 zoom)
+      const newZoom = data.fontSize / DEFAULT_FONT_SIZE;
       const local_view_state = actions.store.get("local_view_state");
       actions.setState({
         local_view_state: local_view_state.setIn([id, "pdf_zoom"], newZoom),
@@ -369,11 +370,8 @@ export function Output(props: OutputProps) {
               const autoSyncInProgress =
                 actions.store.get("autoSyncInProgress");
               if (autoSyncInProgress) {
-                // Debounce the flag clearing to avoid clearing too early during scrolling
-                clearTimeout((window as any).__autoSyncClearTimeout);
-                (window as any).__autoSyncClearTimeout = setTimeout(() => {
-                  actions.setState({ autoSyncInProgress: false });
-                }, 500); // Wait longer to ensure scrolling has stabilized
+                // Clear immediately to allow next forward sync without delay
+                actions.setState({ autoSyncInProgress: false });
               }
             }}
             onPageDimensions={setPageDimensions}

src/packages/frontend/frame-editors/latex-editor/pdfjs.tsx

@@ -35,6 +35,7 @@ import usePinchToZoom, {
 } from "@cocalc/frontend/frame-editors/frame-tree/pinch-to-zoom";
 import { EditorState } from "@cocalc/frontend/frame-editors/frame-tree/types";
 import { list_alternatives, seconds_ago } from "@cocalc/util/misc";
+import { DEFAULT_FONT_SIZE } from "@cocalc/util/consts/ui";
 import { COLORS } from "@cocalc/util/theme";
 import { Actions, Actions as LatexEditorActions } from "./actions";
 import { dblclick } from "./mouse-click";
@@ -248,7 +249,7 @@ export function PDFJS({
     if (evt.key == "0" && (evt.metaKey || evt.ctrlKey)) {
       actions.set_font_size(
         id,
-        redux.getStore("account").get("font_size") ?? 14,
+        redux.getStore("account").get("font_size") ?? DEFAULT_FONT_SIZE,
       );
       return;
     }
@@ -440,7 +441,8 @@ export function PDFJS({
 
     // Use onZoom callback if available (new zoom system), otherwise fall back to font_size
     if (onZoom) {
-      const fontSize = getFontSize(scale);
+      // For zoom-to-fit, always use DEFAULT_FONT_SIZE as base to avoid account font size dependency
+      const fontSize = scale * DEFAULT_FONT_SIZE;
       onZoom({ fontSize });
     } else {
       actions.set_font_size(id, getFontSize(scale));
@@ -464,7 +466,8 @@ export function PDFJS({
 
     // Use onZoom callback if available (new zoom system), otherwise fall back to font_size
     if (onZoom) {
-      const fontSize = getFontSize(scale);
+      // For zoom-to-fit, always use DEFAULT_FONT_SIZE as base to avoid account font size dependency
+      const fontSize = scale * DEFAULT_FONT_SIZE;
       onZoom({ fontSize });
     } else {
       actions.set_font_size(id, getFontSize(scale));
@@ -840,11 +843,16 @@ export function PDFJS({
     if (zoom !== undefined) {
       return zoom;
     }
-    return font_size / (redux.getStore("account").get("font_size") ?? 14);
+    return (
+      font_size /
+      (redux.getStore("account").get("font_size") ?? DEFAULT_FONT_SIZE)
+    );
   }, [zoom, font_size]);
 
   function getFontSize(scale: number): number {
-    return (redux.getStore("account").get("font_size") ?? 14) * scale;
+    return (
+      (redux.getStore("account").get("font_size") ?? DEFAULT_FONT_SIZE) * scale
+    );
   }
 
   function renderOtherViewers() {