Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefectDojo Reporter Fail Fast on Non-Existent Product ID #392

Open
abhisek opened this issue Mar 17, 2025 · 0 comments
Open

DefectDojo Reporter Fail Fast on Non-Existent Product ID #392

abhisek opened this issue Mar 17, 2025 · 0 comments
Assignees
@OmkarPh

Comments

@abhisek
Copy link
Member

abhisek commented Mar 17, 2025

Currently we check if product ID is valid during Finish(...) This seems like a very late failure. The entire scan is finished and only after that we may fail because the product_id was not correct. I think this is a bad DevEx. We should fail early to avoid wasting time for users.

Do you think we should move fetching product ID early during the NewXXX itself?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OmkarPh OmkarPh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abhisek @OmkarPh