Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Empty Upgrade To Version Suggestion in Markdown Summary Report #344

Open
abhisek opened this issue Feb 6, 2025 · 1 comment
Open

Fix Empty Upgrade To Version Suggestion in Markdown Summary Report #344

abhisek opened this issue Feb 6, 2025 · 1 comment
Assignees
@Sahilb315

Comments

@abhisek
Copy link
Member

abhisek commented Feb 6, 2025 •
edited
Loading

See the PR comment by vet-action here:
#341

vet-action internally uses vet's Markdown Summary reporter. The upgrade to version suggestion is empty @. We need to handle the case and prevent a suggestion with empty version.

To reproduce, you can run:

vet scan -D /some/dir --report-markdown-summary /tmp/a.md
Image
@abhisek
Copy link
Member Author

abhisek commented Mar 17, 2025

@Sahilb315 Adding this for you to look at after you are done with your existing stuff.

Sahilb315 added a commit that referenced this issue Mar 18, 2025
@Sahilb315
fixes #344
740718d
@Sahilb315 Sahilb315 mentioned this issue Mar 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sahilb315 Sahilb315

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abhisek @Sahilb315