Changing background doesn't trigger save

[ZebraVogel94349]

Describe the bug

When you open a note, change the background and then exit the note, the new background isn't saved. You have to edit something else in the note for the auto-save to trigger.

To reproduce

1. Open any note
2. Change the background
3. Go back to home screen
4. Open the note again
5. The old background is still there

Expected behavior

Make background changes behave like any other change in a note -> trigger save/need to save

Saber version

v1.30.0

Device

• Device: Samsung Galaxy Tab S7 FE
• OS: Android 14

Anything else?

No response

Before submitting an issue, please check the following

• I have searched for similar issues (both open and closed) and cannot find a duplicate
• This is not an automated submission and has been written by a human.

[ecezyk]

Hello, I reproduced the bug on my phone. Can I work this issue ?

[ZebraVogel94349]

Hello, I reproduced the bug on my phone. Can I work this issue ?

I've looked a bit into this. Auto-save is cancelled if the last history element has already been saved (

saber/lib/pages/editor/editor.dart

Line 881 in b067a18

if (history.isCurrentStateSaved) return cancelAutosaveAndMarkSaved();

). Background changes are not stored in the history at the moment. To fix the issue, you need to implement an EditorHistoryItemType for background pattern changes (in data/editor/editor_history.dart and pages/editor.dart).