fix: deprecated bug, magic number, duplicate constant, empty config

Author: ryanwaits

packages/sdk/src/core/config.ts

@@ -71,11 +71,14 @@ export function mergeConfig(
   }
 
   // CLI options override file config
-  return {
-    externals: {
-      include: cliOptions.externals?.include ?? fileConfig.externals?.include,
-      exclude: cliOptions.externals?.exclude ?? fileConfig.externals?.exclude,
-      depth: cliOptions.externals?.depth ?? fileConfig.externals?.depth,
-    },
+  const externals = {
+    include: cliOptions.externals?.include ?? fileConfig.externals?.include,
+    exclude: cliOptions.externals?.exclude ?? fileConfig.externals?.exclude,
+    depth: cliOptions.externals?.depth ?? fileConfig.externals?.depth,
   };
+
+  // Only include externals if at least one field is defined
+  const hasExternals = externals.include || externals.exclude || externals.depth !== undefined;
+
+  return hasExternals ? { externals } : {};
 }

packages/sdk/src/core/query.ts

@@ -1,12 +1,13 @@
-import type {
-  OpenPkg,
-  SpecExport,
-  SpecExportKind,
-  SpecMember,
-  SpecSchema,
-  SpecSignature,
-  SpecType,
-  SpecTypeParameter,
+import {
+  DISPLAY_KIND_ORDER,
+  type OpenPkg,
+  type SpecExport,
+  type SpecExportKind,
+  type SpecMember,
+  type SpecSchema,
+  type SpecSignature,
+  type SpecType,
+  type SpecTypeParameter,
 } from '@openpkg-ts/spec';
 
 /**
@@ -394,12 +395,7 @@ export function sortByName<T extends { name: string }>(items: T[]): T[] {
 
 /** Canonical kind ordering for rendering grouped exports. */
 export const KIND_ORDER: SpecExportKind[] = [
-  'function',
-  'class',
-  'interface',
-  'type',
-  'enum',
-  'variable',
+  ...DISPLAY_KIND_ORDER,
   'namespace',
   'module',
   'reference',

packages/sdk/src/primitives/list.ts

@@ -131,7 +131,7 @@ function extractExportItem(
   const description = getDescriptionPreview(targetSymbol, checker);
 
   // Check deprecated
-  const deprecated = isSymbolDeprecated(targetSymbol);
+  const { deprecated } = isSymbolDeprecated(targetSymbol);
 
   // Check if from different file (re-export)
   const reexport = isReexport || sourceFile !== entrySourceFile;

packages/sdk/src/types/utils.ts

@@ -1,9 +1,9 @@
-import type ts from 'typescript';
+import ts from 'typescript';
 
 export function isExported(node: ts.Node): boolean {
   const modifiers = (node as ts.HasModifiers).modifiers;
   if (!modifiers) return false;
-  return modifiers.some((m) => m.kind === 95 /* ExportKeyword */);
+  return modifiers.some((m) => m.kind === ts.SyntaxKind.ExportKeyword);
 }
 
 export function getNodeName(node: ts.Node): string | undefined {