Consider eagerly implementing common traits

[lvkv]

My immediate need/use case is Clone on CertificateSigningRequest. After skimming the codebase, however, I'm getting the impression that there are many more opportunities to implement the common traits outlined in the API guidelines. @est31 also echoed this over at #17 (comment).

Prior related work:

• Add Debug to rcgen::Certificate #315 / derive Debug for non-sensitive struct types #316
• Make Certificate cloneable (derive Clone) #319
• and more, probably...

If you're amenable to eagerly implementing these traits, I think it'd be easiest (from a review standpoint) to create a pull request per trait and dedicate each PR to sweeping the codebase and nitpicking the details—similar to #316. I'm open to other approaches too.

• Copy, Clone
  • Eagerly derive Clone, Copy, where possible #341
• Debug
  • derive Debug for non-sensitive struct types #316
  • Eagerly implemented Debug trait #343
• Display
  • (Deemed not necessary for now)
• PartialEq, Eq
  • Eagerly implemented PartialEq and Eq traits #344
• PartialOrd, Ord
  • (Closed) Eagerly implemented PartialOrd and Ord traits #346
• Hash
  • (Closed) Eagerly implemented Hash trait #345
• Default
  • (Deemed not necessary for now)

[cpu]

After skimming the codebase, however, I'm getting the impression that there are many more opportunities to implement the common traits outlined in the API guidelines.

Agreed! I think some of these were harder to take back when some of the params types were holding private data but we're in a better spot now.

I think it'd be easiest (from a review standpoint) to create a pull request per trait and dedicate each PR to sweeping the codebase and nitpicking the details

I'd also be open to one PR with each trait handled per-commit but don't feel strongly.

[djc]

One trait per commit in a single PR sounds good to me.

[lvkv]

#341 was pretty seamless, so I'll open one more PR for all the other common traits—one trait per commit.

[djc]

I think we should stop after the PRs that already exist and wait for someone who has a particular impl they require.

[lvkv]

I think we should stop after the PRs that already exist

Feel free to manage/close this PR whenever, by the way. There are no further requests on my end after #341 🙂.

[Rynibami]

@lvkv I think you check off all items on the list and close this issue now as all PRs related to your list have been merged into main or closed with a reason.

[cpu]

@Rynibami @lvkv Thanks to both of you for your work here. I'll close this as completed.