Move EventLoopExtPumpEvents and PumpStatus to winit-core

Author: madsmtm

examples/pump_events.rs

@@ -9,8 +9,8 @@ fn main() -> std::process::ExitCode {
 
     use winit::application::ApplicationHandler;
     use winit::event::WindowEvent;
+    use winit::event_loop::pump_events::{EventLoopExtPumpEvents, PumpStatus};
     use winit::event_loop::{ActiveEventLoop, EventLoop};
-    use winit::platform::pump_events::{EventLoopExtPumpEvents, PumpStatus};
     use winit::window::{Window, WindowAttributes, WindowId};
 
     #[path = "util/fill.rs"]

src/changelog/unreleased.md

@@ -199,6 +199,7 @@ changelog entry.
 - Renamed "super" key to "meta", to match the naming in the W3C specification.
   `NamedKey::Super` still exists, but it's non-functional and deprecated, `NamedKey::Meta` should be used instead.
 - Move `IconExtWindows` into `WinIcon`.
+- Move `EventLoopExtPumpEvents` and `PumpStatus` from platform module to `winit::event_loop::pump_events`.
 
 ### Removed
 

src/event_loop.rs

@@ -275,7 +275,7 @@ impl AsFd for EventLoop {
     ///
     /// [`calloop`]: https://crates.io/crates/calloop
     /// [`mio`]: https://crates.io/crates/mio
-    /// [`pump_app_events`]: crate::platform::pump_events::EventLoopExtPumpEvents::pump_app_events
+    /// [`pump_app_events`]: crate::event_loop::pump_events::EventLoopExtPumpEvents::pump_app_events
     fn as_fd(&self) -> BorrowedFd<'_> {
         self.event_loop.as_fd()
     }
@@ -289,8 +289,26 @@ impl AsRawFd for EventLoop {
     ///
     /// [`calloop`]: https://crates.io/crates/calloop
     /// [`mio`]: https://crates.io/crates/mio
-    /// [`pump_app_events`]: crate::platform::pump_events::EventLoopExtPumpEvents::pump_app_events
+    /// [`pump_app_events`]: crate::event_loop::pump_events::EventLoopExtPumpEvents::pump_app_events
     fn as_raw_fd(&self) -> RawFd {
         self.event_loop.as_raw_fd()
     }
 }
+
+#[cfg(any(
+    windows_platform,
+    macos_platform,
+    android_platform,
+    x11_platform,
+    wayland_platform,
+    docsrs,
+))]
+impl winit_core::event_loop::pump_events::EventLoopExtPumpEvents for EventLoop {
+    fn pump_app_events<A: ApplicationHandler>(
+        &mut self,
+        timeout: Option<std::time::Duration>,
+        app: A,
+    ) -> winit_core::event_loop::pump_events::PumpStatus {
+        self.event_loop.pump_app_events(timeout, app)
+    }
+}

src/lib.rs

@@ -32,16 +32,8 @@
 //! Winit no longer uses a `EventLoop::poll_events() -> impl Iterator<Event>`-based event loop
 //! model, since that can't be implemented properly on some platforms (e.g Web, iOS) and works
 //! poorly on most other platforms. However, this model can be re-implemented to an extent with
-#![cfg_attr(
-    any(windows_platform, macos_platform, android_platform, x11_platform, wayland_platform),
-    doc = "[`EventLoopExtPumpEvents::pump_app_events()`][platform::pump_events::EventLoopExtPumpEvents::pump_app_events()]"
-)]
-#![cfg_attr(
-    not(any(windows_platform, macos_platform, android_platform, x11_platform, wayland_platform)),
-    doc = "`EventLoopExtPumpEvents::pump_app_events()`"
-)]
-//! [^1]. See that method's documentation for more reasons about why
-//! it's discouraged beyond compatibility reasons.
+//! [`EventLoopExtPumpEvents::pump_app_events()`] [^1]. See that method's documentation for more
+//! reasons about why it's discouraged beyond compatibility reasons.
 //!
 //!
 //! ```no_run
@@ -276,6 +268,7 @@
 //! [`DeviceEvent`]: event::DeviceEvent
 //! [`raw_window_handle`]: ./window/struct.Window.html#method.raw_window_handle
 //! [`raw_display_handle`]: ./window/struct.Window.html#method.raw_display_handle
+//! [`EventLoopExtPumpEvents::pump_app_events()`]: crate::event_loop::pump_events::EventLoopExtPumpEvents::pump_app_events()
 //! [^1]: `EventLoopExtPumpEvents::pump_app_events()` is only available on Windows, macOS, Android, X11 and Wayland.
 
 #![deny(rust_2018_idioms)]

src/platform/mod.rs

@@ -32,15 +32,5 @@ pub mod x11;
 ))]
 pub mod run_on_demand;
 
-#[cfg(any(
-    windows_platform,
-    macos_platform,
-    android_platform,
-    x11_platform,
-    wayland_platform,
-    docsrs,
-))]
-pub mod pump_events;
-
 #[cfg(any(windows_platform, macos_platform, x11_platform, wayland_platform, docsrs))]
 pub mod scancode;

src/platform/run_on_demand.rs

@@ -3,7 +3,8 @@ use crate::error::EventLoopError;
 use crate::event_loop::EventLoop;
 #[cfg(doc)]
 use crate::{
-    event_loop::ActiveEventLoop, platform::pump_events::EventLoopExtPumpEvents, window::Window,
+    event_loop::{pump_events::EventLoopExtPumpEvents, ActiveEventLoop},
+    window::Window,
 };
 
 /// Additional methods on [`EventLoop`] to return control flow to the caller.

src/platform_impl/android/mod.rs

@@ -9,6 +9,7 @@ use android_activity::{
     AndroidApp, AndroidAppWaker, ConfigurationRef, InputStatus, MainEvent, Rect,
 };
 use tracing::{debug, trace, warn};
+use winit_core::event_loop::pump_events::PumpStatus;
 
 use crate::application::ApplicationHandler;
 use crate::cursor::{Cursor, CustomCursor, CustomCursorSource};
@@ -21,7 +22,6 @@ use crate::event_loop::{
     OwnedDisplayHandle as CoreOwnedDisplayHandle,
 };
 use crate::monitor::{Fullscreen, MonitorHandle as CoreMonitorHandle};
-use crate::platform::pump_events::PumpStatus;
 use crate::window::{
     self, CursorGrabMode, ImePurpose, ResizeDirection, Theme, Window as CoreWindow,
     WindowAttributes, WindowButtons, WindowId, WindowLevel,

src/platform_impl/apple/appkit/event_loop.rs

@@ -15,6 +15,7 @@ use objc2_app_kit::{
 };
 use objc2_foundation::{NSNotificationCenter, NSObjectProtocol};
 use rwh_06::HasDisplayHandle;
+use winit_core::event_loop::pump_events::PumpStatus;
 
 use super::super::notification_center::create_observer;
 use super::app::override_send_event;
@@ -32,7 +33,6 @@ use crate::event_loop::{
 };
 use crate::monitor::MonitorHandle as CoreMonitorHandle;
 use crate::platform::macos::ActivationPolicy;
-use crate::platform::pump_events::PumpStatus;
 use crate::platform_impl::Window;
 use crate::window::Theme;
 

src/platform_impl/linux/mod.rs

@@ -7,13 +7,14 @@ use std::env;
 use std::os::unix::io::{AsFd, AsRawFd, BorrowedFd, RawFd};
 use std::time::Duration;
 
+use winit_core::event_loop::pump_events::PumpStatus;
+
 pub(crate) use self::common::xkb::{physicalkey_to_scancode, scancode_to_physicalkey};
 use crate::application::ApplicationHandler;
 #[cfg(x11_platform)]
 use crate::dpi::Size;
 use crate::error::{EventLoopError, NotSupportedError};
 use crate::event_loop::ActiveEventLoop;
-use crate::platform::pump_events::PumpStatus;
 #[cfg(x11_platform)]
 use crate::platform::x11::WindowType as XWindowType;
 use crate::window::ActivationToken;

src/platform_impl/linux/wayland/event_loop/mod.rs

@@ -16,6 +16,7 @@ use rustix::pipe::{self, PipeFlags};
 use sctk::reexports::calloop_wayland_source::WaylandSource;
 use sctk::reexports::client::{globals, Connection, QueueHandle};
 use tracing::warn;
+use winit_core::event_loop::pump_events::PumpStatus;
 
 use crate::application::ApplicationHandler;
 use crate::cursor::{CustomCursor as CoreCustomCursor, CustomCursorSource};
@@ -27,7 +28,6 @@ use crate::event_loop::{
     OwnedDisplayHandle as CoreOwnedDisplayHandle,
 };
 use crate::monitor::MonitorHandle as CoreMonitorHandle;
-use crate::platform::pump_events::PumpStatus;
 use crate::platform_impl::platform::min_timeout;
 use crate::platform_impl::wayland::types::cursor::WaylandCustomCursor;
 use crate::window::Theme;