Fix new Rust 1.83 clippy lints (#198)

* Fix new Rust 1.83 clippy lints

* macos: Install `lld` as a separate "formula" and fix `llvm` `PATH`

Author: MarijnS95

.github/workflows/ci.yml

@@ -77,8 +77,8 @@ jobs:
     - name: install llvm macos
       if: ${{ matrix.host == 'macos-latest' }}
       run: |
-        brew install llvm
-        echo "/usr/local/opt/llvm/bin" >> $GITHUB_PATH
+        brew install llvm lld
+        echo "/opt/homebrew/opt/llvm/bin" >> $GITHUB_PATH
 
     - name: install java
       uses: actions/setup-java@v2

apk/src/compiler/table.rs

@@ -144,7 +144,7 @@ pub struct Entry<'a> {
     entry: &'a ResTableEntry,
 }
 
-impl<'a> Entry<'a> {
+impl Entry<'_> {
     pub fn id(self) -> ResTableRef {
         self.id
     }

apk/src/res.rs

@@ -932,7 +932,7 @@ impl Chunk {
                                 break;
                             }
                         }
-                        let s = String::from_utf16(unsafe { std::mem::transmute(buf.as_slice()) })?;
+                        let s = String::from_utf16(buf.as_slice())?;
                         strings.push(s);
                     }
                 }

mvn/src/package.rs

@@ -143,7 +143,7 @@ pub struct Artifact<'a> {
     pub version: &'a Version,
 }
 
-impl<'a> Artifact<'a> {
+impl Artifact<'_> {
     pub fn file_name(self, ext: &str) -> String {
         format!(
             "{}-{}-{}.{}",
@@ -163,7 +163,7 @@ impl<'a> Artifact<'a> {
     }
 }
 
-impl<'a> std::fmt::Display for Artifact<'a> {
+impl std::fmt::Display for Artifact<'_> {
     fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
         write!(
             f,

mvn/src/pom.rs

@@ -14,11 +14,7 @@ pub struct Pom {
 
 impl Pom {
     pub fn packaging(&self) -> &str {
-        if let Some(s) = self.packaging.as_deref() {
-            s
-        } else {
-            "jar"
-        }
+        self.packaging.as_deref().unwrap_or("jar")
     }
 
     pub fn dependencies(&self) -> &[Dependency] {

xbuild/src/download.rs

@@ -15,7 +15,7 @@ pub struct DownloadManager<'a> {
     client: Client,
 }
 
-impl<'a> Download for DownloadManager<'a> {
+impl Download for DownloadManager<'_> {
     fn download(&self, url: &str, dest: &Path) -> Result<()> {
         let pb = ProgressBar::with_draw_target(Some(0), ProgressDrawTarget::stdout())
         .with_style(
@@ -233,7 +233,7 @@ impl WorkItem {
     }
 }
 
-impl<'a> DownloadManager<'a> {
+impl DownloadManager<'_> {
     pub fn android_jar(&self) -> Result<()> {
         let dir = self.env.android_sdk();
         let sdk = self.env.target_sdk_version();

xcommon/src/lib.rs

@@ -248,7 +248,7 @@ fn find_cde_start_pos<R: Read + Seek>(reader: &mut R) -> Result<u64> {
     const CENTRAL_DIRECTORY_END_SIGNATURE: u32 = 0x06054b50;
     const HEADER_SIZE: u64 = 22;
     let file_length = reader.seek(SeekFrom::End(0))?;
-    let search_upper_bound = file_length.saturating_sub(HEADER_SIZE + ::std::u16::MAX as u64);
+    let search_upper_bound = file_length.saturating_sub(HEADER_SIZE + u16::MAX as u64);
     anyhow::ensure!(file_length >= HEADER_SIZE, "Invalid zip header");
     let mut pos = file_length - HEADER_SIZE;
     while pos >= search_upper_bound {