Open
Description
When parsing workspace.members
, the result of glob matching doesn't filter directories. It will gladly append Cargo.toml
to file paths like README.md
:
cargo-subcommand/src/manifest.rs
Lines 38 to 42 in de0458c
Assumes a manifest being parsed contains:
[workspace]
members = [
"examples/*",
"tests/*",
]
... and these directories contain a README.md
or other files as direct children. An example repo in the wild where this is done:
egui
:
This kind of setup causes Subcommand::new()
to return an error here:
cargo-subcommand/src/subcommand.rs
Lines 67 to 71 in de0458c
The glob
result needs to be filtered to match directories. Checking manifest_dir.is_dir()
is a good start, but symlinks also need to be followed.
Metadata
Metadata
Assignees
Labels
No labels