Skip to content

Commit 5301321

Browse files
committed
Pluralize merge-conflicts
Personal preference, felt better this way.
1 parent e4d1bc2 commit 5301321

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

src/config.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ pub(crate) struct Config {
4545
pub(crate) validate_config: Option<ValidateConfig>,
4646
pub(crate) pr_tracking: Option<ReviewPrefsConfig>,
4747
pub(crate) transfer: Option<TransferConfig>,
48-
pub(crate) merge_conflict: Option<MergeConflictConfig>,
48+
pub(crate) merge_conflicts: Option<MergeConflictConfig>,
4949
}
5050

5151
#[derive(PartialEq, Eq, Debug, serde::Deserialize)]
@@ -540,7 +540,7 @@ mod tests {
540540
validate_config: Some(ValidateConfig {}),
541541
pr_tracking: None,
542542
transfer: None,
543-
merge_conflict: None,
543+
merge_conflicts: None,
544544
}
545545
);
546546
}

src/handlers.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ mod github_releases;
3131
mod glacier;
3232
mod major_change;
3333
mod mentions;
34-
mod merge_conflict;
34+
mod merge_conflicts;
3535
mod milestone_prs;
3636
mod no_merges;
3737
mod nominate;
@@ -145,10 +145,14 @@ pub async fn handle(ctx: &Context, event: &Event) -> Vec<HandlerError> {
145145
}
146146
}
147147

148-
if let Some(conflict_config) = config.as_ref().ok().and_then(|c| c.merge_conflict.as_ref()) {
149-
if let Err(e) = merge_conflict::handle(ctx, event, conflict_config).await {
148+
if let Some(conflict_config) = config
149+
.as_ref()
150+
.ok()
151+
.and_then(|c| c.merge_conflicts.as_ref())
152+
{
153+
if let Err(e) = merge_conflicts::handle(ctx, event, conflict_config).await {
150154
log::error!(
151-
"failed to process event {:?} with merge_conflict handler: {:?}",
155+
"failed to process event {:?} with merge_conflicts handler: {:?}",
152156
event,
153157
e
154158
);

src/handlers/merge_conflict.rs renamed to src/handlers/merge_conflicts.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ use tokio_postgres::Client as DbClient;
3131
use tracing as log;
3232

3333
/// Key for the database.
34-
const MERGE_CONFLICT_KEY: &str = "merge-conflict";
34+
const MERGE_CONFLICTS_KEY: &str = "merge-conflicts";
3535

3636
/// The amount of time to wait before scanning an unknown mergeable status.
3737
///
@@ -262,7 +262,7 @@ async fn maybe_add_comment(
262262
possibly: Option<&str>,
263263
) -> anyhow::Result<()> {
264264
let mut state: IssueData<'_, MergeConflictState> =
265-
IssueData::load(db, issue, MERGE_CONFLICT_KEY).await?;
265+
IssueData::load(db, issue, MERGE_CONFLICTS_KEY).await?;
266266
if state.data.last_warned_comment.is_some() {
267267
// There was already an unresolved notification, don't warn again.
268268
return Ok(());
@@ -308,7 +308,7 @@ async fn maybe_hide_comment(
308308
issue: &Issue,
309309
) -> anyhow::Result<()> {
310310
let mut state: IssueData<'_, MergeConflictState> =
311-
IssueData::load(db, issue, MERGE_CONFLICT_KEY).await?;
311+
IssueData::load(db, issue, MERGE_CONFLICTS_KEY).await?;
312312
let Some(comment_id) = &state.data.last_warned_comment else {
313313
return Ok(());
314314
};

0 commit comments

Comments
 (0)