Skip to content

Commit 37d04d7

Browse files
authored
Merge pull request #1711 from apiraino/t-compiler-meeting-agenda-updates
Updates to the T-compiler meeting agenda
2 parents d18ba48 + f790bb2 commit 37d04d7

File tree

4 files changed

+30
-38
lines changed

4 files changed

+30
-38
lines changed

src/agenda.rs

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -169,15 +169,6 @@ pub fn prioritization<'a>() -> Box<dyn Action> {
169169
exclude_labels: vec!["beta-accepted"],
170170
}),
171171
},
172-
QueryMap {
173-
name: "beta_nominated_t_rustdoc",
174-
kind: QueryKind::List,
175-
query: Arc::new(github::Query {
176-
filters: vec![],
177-
include_labels: vec!["beta-nominated", "T-rustdoc"],
178-
exclude_labels: vec!["beta-accepted"],
179-
}),
180-
},
181172
// stable nomination queries
182173
QueryMap {
183174
name: "stable_nominated_t_compiler",
@@ -188,15 +179,6 @@ pub fn prioritization<'a>() -> Box<dyn Action> {
188179
exclude_labels: vec!["stable-accepted"],
189180
}),
190181
},
191-
QueryMap {
192-
name: "stable_nominated_t_rustdoc",
193-
kind: QueryKind::List,
194-
query: Arc::new(github::Query {
195-
filters: vec![],
196-
include_labels: vec!["stable-nominated", "T-rustdoc"],
197-
exclude_labels: vec!["stable-accepted"],
198-
}),
199-
},
200182
// prs waiting on team queries
201183
QueryMap {
202184
name: "prs_waiting_on_team_t_compiler",

templates/_issue.tt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{% macro render(issue, with_age="") %}"{{issue.title}}" [{{issue.repo_name}}#{{issue.number}}]({{issue.html_url}}) {% if with_age %}(last review activity: {{issue.updated_at_hts}}){% endif %}{% endmacro %}
1+
{% macro render(issue, with_age="") %}"{{issue.title}}" [{{issue.repo_name}}#{{issue.number}}]({{issue.html_url}}){% if with_age %}(last review activity: {{issue.updated_at_hts}}){% endif %}{% endmacro %}

templates/_issues.tt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{% import "_issue.tt" as issue %}
22

3-
{% macro render(issues, indent="", branch="", with_age=false, empty="No issues this time.") %}
3+
{% macro render(issues, indent="", branch="", with_age=false, empty="No issues at this time.") %}
44
{#- If "branch" is not empty add a trailing space but no newlines before or after -#}
55
{%- if branch -%}
66
{%- set branch = branch ~ " " -%}

templates/prioritization_agenda.tt

Lines changed: 28 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
---
55
tags: weekly, rustc
6+
type: docs
67
---
78

89
# T-compiler Meeting Agenda YYYY-MM-DD
@@ -39,35 +40,35 @@ tags: weekly, rustc
3940
(TIP) pick from [here](https://rust-lang.github.io/compiler-team/about/triage-meeting/#working-group-check-in)
4041

4142
@*WG-X* checkin by @**person1** ([previous checkin](https://hackmd.io/team/rust-compiler-team?nav=overview)):
42-
> Checkin text
43+
> Checkin text
4344

4445
@*WG-Y* checkin by @**person2** ([previous checkin](https://hackmd.io/team/rust-compiler-team?nav=overview)):
45-
> Checkin text
46+
> Checkin text
4647

4748
## Backport nominations
4849

4950
[T-compiler stable](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted+label%3AT-compiler) / [T-compiler beta](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted+label%3AT-compiler)
5051
{{-issues::render(issues=beta_nominated_t_compiler, branch=":beta:", empty="No beta nominations for `T-compiler` this time.")}}
52+
<!--
53+
/poll Approve beta backport of #12345?
54+
approve
55+
decline
56+
don't know
57+
-->
5158
{{-issues::render(issues=stable_nominated_t_compiler, branch=":stable:", empty="No stable nominations for `T-compiler` this time.")}}
52-
53-
[T-rustdoc stable](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted+label%3AT-rustdoc) / [T-rustdoc beta](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted+label%3AT-rustdoc)
54-
{{-issues::render(issues=beta_nominated_t_rustdoc, branch=":beta:", empty="No beta nominations for `T-rustdoc` this time.")}}
55-
{{-issues::render(issues=stable_nominated_t_rustdoc, branch=":stable:", empty="No stable nominations for `T-rustdoc` this time.")}}
56-
57-
:back: / :shrug: / :hand:
59+
<!--
60+
/poll Approve stable backport of #12345?
61+
approve
62+
approve but does not justify new dot release
63+
decline
64+
don't know
65+
-->
5866

5967
## PRs S-waiting-on-team
6068

6169
[T-compiler](https://github.com/rust-lang/rust/pulls?q=is%3Aopen+label%3AS-waiting-on-team+label%3AT-compiler)
6270
{{-issues::render(issues=prs_waiting_on_team_t_compiler, empty="No PRs waiting on `T-compiler` this time.")}}
6371

64-
### Oldest PRs waiting for review
65-
66-
(TIP) Curate this list before the meeting
67-
68-
[T-compiler](https://github.com/rust-lang/rust/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-asc+label%3AS-waiting-on-review+draft%3Afalse+label%3AT-compiler)
69-
{{-issues::render(issues=top_unreviewed_prs, with_age=true, empty="No unreviewed PRs on `T-compiler` this time.")}}
70-
7172
## Issues of Note
7273

7374
### Short Summary
@@ -83,13 +84,13 @@ tags: weekly, rustc
8384
### P-critical
8485

8586
[T-compiler](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-critical+label%3AT-compiler)
86-
{{-issues::render(issues=p_critical_t_compiler, empty="No `P-critical` issues for `T-compiler` at this time.")}}
87+
{{-issues::render(issues=p_critical_t_compiler, empty="No `P-critical` issues for `T-compiler` this time.")}}
8788

8889
[T-types](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-critical+label%3AT-types)
89-
{{-issues::render(issues=p_critical_t_types, empty="No `P-critical` issues for `T-types` at this time.")}}
90+
{{-issues::render(issues=p_critical_t_types, empty="No `P-critical` issues for `T-types` this time.")}}
9091

9192
[T-rustdoc](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-critical+label%3AT-rustdoc)
92-
{{-issues::render(issues=p_critical_t_rustdoc, empty="No `P-critical` issues for `T-rustdoc` at this time.")}}
93+
{{-issues::render(issues=p_critical_t_rustdoc, empty="No `P-critical` issues for `T-rustdoc` this time.")}}
9394

9495
### P-high regressions
9596

@@ -111,7 +112,16 @@ tags: weekly, rustc
111112
[RFC](https://github.com/rust-lang/rfcs/issues?q=is%3Aopen+label%3AI-compiler-nominated)
112113
{{-issues::render(issues=nominated_rfcs_t_compiler, empty="No I-compiler-nominated RFCs this time.")}}
113114

115+
### Oldest PRs waiting for review
116+
117+
(TIP) Curate this list before the meeting
118+
119+
[T-compiler](https://github.com/rust-lang/rust/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-asc+label%3AS-waiting-on-review+draft%3Afalse+label%3AT-compiler)
120+
{{-issues::render(issues=top_unreviewed_prs, with_age=true, empty="No unreviewed PRs on `T-compiler` this time.")}}
121+
114122
## Next week's WG checkins
115123

116124
- @*WG-X* checkin by @**person1**
117125
- @*WG-X* checkin by @**person2**
126+
127+
Next meetings' agenda draft: `<hackmd link>`

0 commit comments

Comments
 (0)