Skip to content

Docker image riscv64 objdump does not support extension instructions yet. #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
coastalwhite opened this issue Aug 31, 2023 · 0 comments · Fixed by #1467
Closed

Docker image riscv64 objdump does not support extension instructions yet. #1464

coastalwhite opened this issue Aug 31, 2023 · 0 comments · Fixed by #1467

Comments

@coastalwhite
Copy link
Contributor

coastalwhite commented Aug 31, 2023 •
edited
Loading

Found as part of #1453 and #1461.

The current implementation does not use the assert_instr macro to test for the presence of the riscv64 intrinsics. Therefore, the assert_instr tests for these instructions are disabled.

Currently, the extensions are not supported by both the stable and rolling Ubuntu version's objdump. When docker image gets updated to a version that does support these instructions, the tests should be readded.
coastalwhite added a commit to coastalwhite/stdarch that referenced this issue Aug 31, 2023
@coastalwhite
Fix: Remove assert_instr for RISCV, see rust-lang#1464
e672eca
Amanieu pushed a commit that referenced this issue Aug 31, 2023
@coastalwhite @Amanieu
Fix: Remove assert_instr for RISCV, see #1464
6b9082f
coastalwhite added a commit to coastalwhite/stdarch that referenced this issue Sep 16, 2023
@coastalwhite
Fix: rust-lang#1464 for rv64 zk
6b72eb6
coastalwhite added a commit to coastalwhite/stdarch that referenced this issue Sep 16, 2023
@coastalwhite
Fix: rust-lang#1464 for rv64 zb
49b73f5
@coastalwhite coastalwhite mentioned this issue Sep 16, 2023
Merged
Amanieu pushed a commit that referenced this issue Sep 22, 2023
@coastalwhite @Amanieu
Fix: #1464 for rv64 zk
839c9ec
Amanieu pushed a commit that referenced this issue Sep 22, 2023
@coastalwhite @Amanieu
Fix: #1464 for rv64 zb
51f2b1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reenable RISC-V Zk and Zb assert_instr coastalwhite/stdarch
1 participant
@coastalwhite