Skip to content

Commit 9bef46d

Browse files
authored
Merge pull request #396 from jdno/aws-access-crates-io
Grant the crates.io team access to new AWS accounts
2 parents 10c525e + e2075c6 commit 9bef46d

File tree

3 files changed

+22
-13
lines changed

3 files changed

+22
-13
lines changed

terragrunt/accounts/root/aws-organization/terragrunt.hcl

+6
Original file line numberDiff line numberDiff line change
@@ -57,5 +57,11 @@ inputs = {
5757
5858
groups = ["infra"]
5959
}
60+
"tobias" = {
61+
given_name = "Tobias"
62+
family_name = "Bieniek"
63+
64+
groups = ["crates-io"]
65+
}
6066
}
6167
}

terragrunt/modules/aws-organization/groups.tf

+15-13
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,7 @@ resource "aws_ssoadmin_permission_set" "read_only_access" {
8181

8282
resource "aws_ssoadmin_managed_policy_attachment" "read_only_access" {
8383
instance_arn = local.instance_arn
84-
managed_policy_arn = "arn:aws:iam::aws:policy/job-function/ViewOnlyAccess"
85-
permission_set_arn = aws_ssoadmin_permission_set.read_only_access.arn
86-
}
87-
88-
resource "aws_ssoadmin_managed_policy_attachment" "cloudwatch_readonly" {
89-
instance_arn = local.instance_arn
90-
managed_policy_arn = "arn:aws:iam::aws:policy/CloudWatchLogsReadOnlyAccess"
84+
managed_policy_arn = "arn:aws:iam::aws:policy/ReadOnlyAccess"
9185
permission_set_arn = aws_ssoadmin_permission_set.read_only_access.arn
9286
}
9387

@@ -124,23 +118,31 @@ locals {
124118
account : aws_organizations_account.crates_io_staging,
125119
groups : [
126120
{ group : aws_identitystore_group.infra-admins,
127-
permissions : [aws_ssoadmin_permission_set.view_only_access, aws_ssoadmin_permission_set.administrator_access] },
121+
permissions : [
122+
aws_ssoadmin_permission_set.view_only_access,
123+
aws_ssoadmin_permission_set.read_only_access,
124+
aws_ssoadmin_permission_set.administrator_access
125+
] },
128126
{ group : aws_identitystore_group.infra,
129-
permissions : [aws_ssoadmin_permission_set.view_only_access, aws_ssoadmin_permission_set.administrator_access] },
127+
permissions : [aws_ssoadmin_permission_set.read_only_access, aws_ssoadmin_permission_set.administrator_access] },
130128
{ group : aws_identitystore_group.crates_io,
131-
permissions : [aws_ssoadmin_permission_set.view_only_access] },
129+
permissions : [aws_ssoadmin_permission_set.read_only_access] },
132130
]
133131
},
134132
# crates-io Production
135133
{
136134
account : aws_organizations_account.crates_io_prod,
137135
groups : [
138136
{ group : aws_identitystore_group.infra-admins,
139-
permissions : [aws_ssoadmin_permission_set.view_only_access, aws_ssoadmin_permission_set.administrator_access] },
137+
permissions : [
138+
aws_ssoadmin_permission_set.view_only_access,
139+
aws_ssoadmin_permission_set.read_only_access,
140+
aws_ssoadmin_permission_set.administrator_access
141+
] },
140142
{ group : aws_identitystore_group.infra,
141-
permissions : [aws_ssoadmin_permission_set.view_only_access] },
143+
permissions : [aws_ssoadmin_permission_set.read_only_access, aws_ssoadmin_permission_set.administrator_access] },
142144
{ group : aws_identitystore_group.crates_io,
143-
permissions : [aws_ssoadmin_permission_set.view_only_access] },
145+
permissions : [aws_ssoadmin_permission_set.read_only_access] },
144146
]
145147
},
146148
# docs-rs Staging

terragrunt/modules/aws-organization/users.tf

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ locals {
33
billing : aws_identitystore_group.billing
44
infra : aws_identitystore_group.infra
55
infra-admins : aws_identitystore_group.infra-admins
6+
crates-io : aws_identitystore_group.crates_io
67
}
78

89
# Expand var.users into collection of group memberships associations

0 commit comments

Comments
 (0)