Skip to content

Commit d57fbde

Browse files
authored
Merge pull request #1547 from Manishearth/progress-hours
Improve formatting of longer download times in download tracker
2 parents 79ed5bd + 17a7778 commit d57fbde

File tree

1 file changed

+18
-3
lines changed

1 file changed

+18
-3
lines changed

src/rustup-cli/download_tracker.rs

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,10 +177,25 @@ impl fmt::Display for HumanReadable {
177177

178178
if sec.is_infinite() {
179179
write!(f, "Unknown")
180-
} else if sec > 1e3 {
180+
} else if sec > 48. * 3600. {
181181
let sec = self.0 as u64;
182-
let min = sec / 60;
183-
let sec = sec % 60;
182+
let d = sec / (24. * 3600.);
183+
let h = sec % (24. * 3600.);
184+
let min = sec % 3600.;
185+
let sec = sec % 60.;
186+
187+
write!(f, "{:3} days {:2} h {:2} min {:2} s", d, h, min, sec) // XYZ days PQ h RS min TU s
188+
} else if sec > 6_000. {
189+
let sec = self.0 as u64;
190+
let h = sec / 3600.;
191+
let min = sec % 3600.;
192+
let sec = sec % 60.;
193+
194+
write!(f, "{:3} h {:2} min {:2} s", h, min, sec) // XYZ h PQ min RS s
195+
} else if sec > 100 {
196+
let sec = self.0 as u64;
197+
let min = sec / 60.;
198+
let sec = sec % 60.;
184199

185200
write!(f, "{:3} min {:2} s", min, sec) // XYZ min PQ s
186201
} else {

0 commit comments

Comments
 (0)