refactor(rustup-mode)!: remove redundant ExitCode in self_update()'s callback

Author: rami3l

src/cli/common.rs

@@ -308,13 +308,14 @@ pub(crate) async fn update_all_channels(
                 .collect();
             show_channel_updates(cfg, t)?;
         }
-        Ok(utils::ExitCode(0))
+        Ok(())
     };
 
     if do_self_update {
         self_update(show_channel_updates, cfg.process).await
     } else {
-        show_channel_updates()
+        show_channel_updates()?;
+        Ok(utils::ExitCode(0))
     }
 }
 
@@ -358,7 +359,7 @@ pub(crate) fn self_update_permitted(explicit: bool) -> Result<SelfUpdatePermissi
 /// Performs all of a self-update: check policy, download, apply and exit.
 pub(crate) async fn self_update<F>(before_restart: F, process: &Process) -> Result<utils::ExitCode>
 where
-    F: FnOnce() -> Result<utils::ExitCode>,
+    F: FnOnce() -> Result<()>,
 {
     match self_update_permitted(false)? {
         SelfUpdatePermission::HardFail => {

src/cli/rustup_mode.rs

@@ -862,7 +862,7 @@ async fn update(cfg: &mut Cfg<'_>, opts: UpdateOpts) -> Result<utils::ExitCode>
             }
         }
         if self_update {
-            common::self_update(|| Ok(utils::ExitCode(0)), cfg.process).await?;
+            common::self_update(|| Ok(()), cfg.process).await?;
         }
     } else {
         common::update_all_channels(cfg, self_update, opts.force).await?;