-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Labels
bugSomething isn't workingSomething isn't working
Description
cargo features are supposed to be additive, but rustc-hash isn't.
Consider the case where:
- Crate
adepends onrustdoc-typeswith default features- Crate
arelies on the HashMap using the default hasher.
- Crate
- Crate
bdepends onrustdoc-typeswithrustc-hashfeature. - Crate
cdepends onaandb
- Cargo does feature unification, and builds
aagainsrustdoc-typeswithrustc-hashenabled. afails to compile.
Potential fixes
- Ignore this, and hope it doesn't effect anyone
- Implement our own
BuildHashertype that doesn't expose the underlying hashing algo, so changing it is additive - Drop the
rustc-hashfeature, and always use it.
3.1. Drop therustc-hashfeature, and never use it. - Make
Crategeneric over the hasher type.
I think it's fine to go with 1 for now, but I'm filling this issue so I don't forget this.
Originally reported by @Noratrieb on fediverse
Caused by #42
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working