Only generate miri backtraces if explicitly requested#49083
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 17, 2018
Merged
Only generate miri backtraces if explicitly requested#49083bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ |
Collaborator
|
📌 Commit 4133b16 has been approved by |
bors
added
S-waiting-on-bors
Member
|
@bors: rollup |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 17, 2018
…aelwoerister Only generate miri backtraces if explicitly requested fixes rust-lang#49072 fixes rust-lang#48888 r? @michaelwoerister
bors
added a commit
that referenced
this pull request
Mar 17, 2018
pravic
reviewed
Mar 17, 2018
| fn from(kind: EvalErrorKind<'tcx>) -> Self { | ||
| let backtrace = match env::var("RUST_BACKTRACE") { | ||
| let backtrace = match env::var("MIRI_BACKTRACE") { | ||
| Ok(ref val) if !val.is_empty() => Some(Backtrace::new_unresolved()), |
Contributor
There was a problem hiding this comment.
So, it looks like backtrace will be generated even with RUST_BACKTRACE=0. Is this okay?
Contributor
Author
There was a problem hiding this comment.
Yes. This is not your regular backtrace, this is inside miri for debugging miri error sources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #49072
fixes #48888
r? @michaelwoerister