Fix test for issue 80706#103635
Closed
Rageking8 wants to merge 1 commit intorust-lang:masterfrom
Rageking8:fix-test-for-issue-80706
Closed
Fix test for issue 80706#103635Rageking8 wants to merge 1 commit intorust-lang:masterfrom Rageking8:fix-test-for-issue-80706
Rageking8 wants to merge 1 commit intorust-lang:masterfrom
Rageking8:fix-test-for-issue-80706
Conversation
rustbot
added
S-waiting-on-review
Contributor
|
What's exactly going on here? All of these changes look superficial except for removing |
Contributor
Author
I removed that erroneous change, since the remaining changes are pretty superficial we can just go with it or just close this PR and the issue above, since I believe the issue is fixed. Compiler-errors, your call. |
Contributor
Author
Contributor
|
The file is syntactically equivalent except for some formatting and ordering of items, so this PR doesn't do anything as far as I can tell. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80706
Actually afaict the test is already good (i.e. the
check-passhad already long been changed tobuild-passto catch the ICE during codegen (flagged out by tmandry)). So this PR just cleans the test up. Correct me if I am wrong. cc @compiler-errors since you last edited this file.r? @lcnr