-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Annotate blocks that must run in constant time regardless of inputs #9859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
Triage. This seems useful, but very complex and probably out of scope for now. |
Agreed that it's out of scope since it requires llvm-side guarantee. It's possible to write constant-time code with |
I'm pulling a massive triage effort to get us ready for 1.0. As part of this, I'm moving stuff that's wishlist-like to the RFCs repo, as that's where major new things should get discussed/prioritized. This issue has been moved to the RFCs repo: rust-lang/rfcs#847 |
Avoid generating files via doctest When we run `cargo test` in `clippy_lints` directory, it will generate [`foo.txt`](https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/foo.txt) in the directory. In order to avoid that, this PR adds `no_run` to rustdoc which contains `File::create`. changelog: none
In a whole bunch of security-related contexts it's important to write code that runs in constant time regardless of input; the obvious example is that if you compare two strings character-by-character for equality and break out of the loop when you hit the first difference, someone might learn how much of their forged authentication token (for example) was correct by measuring the time it took to fail.
Constant-time code requires careful programming, but in the general case it also requires compiler support -- at minimum, it has to be possible to disable optimizations that would convert
a|b
toa||b
in the name of speed, or similar. Ideally, though, the compiler would verify that an annotated block would execute in constant time, and fail the compilation if it was impossible to guarantee that of the generated code.I think the natural way to expose this in Rust is a
#[constant_time]
annotation that could be applied to blocks. Most of the heavy lifting, however, probably needs to be done in the LLVM core.The text was updated successfully, but these errors were encountered: