Double-check cfg_version
test coverage
#141452
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
F-cfg_version
`#![feature(cfg_version)]`
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
#[cfg(version("1.49.0"))]
to be this feature-gate test without#![feature(cfg_version)]
and the user should get the "this is unstable" error message.version(..)
as a sort of "interface". In particular, I'd consider splitting tests for:version(..)
): known vs unknown major version string "1", known vs unknown major-minor version string, known vs unknown major-minor-patch version string, empty version string, some "hello world" nonsense version string.version = ".."
or bareversion
).--cfg version
or--cfg version=".."
they are not affected and usable with or without feature gate (I need to double-check that).This is also fine as a follow-up, I can probably write those coverage.
Originally posted by @jieyouxu in #141413 (comment)
The text was updated successfully, but these errors were encountered: