ICE: expr in place where literal is expected (builtin attr parsing)

[matthiaskrgr]

auto-reduced (treereduce-rust):

//@compile-flags: --crate-type=lib
#[crate_name = concat!("Cloneb")]

macro_rules! inline {
    () => {};
}

original:

#[crate_name = concat!("Cloneb")]
macro_rules! mac {
    ($ident:ident) => { let $ident = 42; }
}

#[macro_export]
macro_rules! inline {
    () => ()
}

Version information

rustc 1.87.0-nightly (ac91805f3 2025-02-26)
binary: rustc
commit-hash: ac91805f3179fc2225c60e8ccf5a1daa09d43f3d
commit-date: 2025-02-26
host: x86_64-unknown-linux-gnu
release: 1.87.0-nightly
LLVM version: 20.1.0

Command:
/home/matthias/.rustup/toolchains/master/bin/rustc --crate-type=lib

Program output

warning: unused macro definition: `inline`
 --> /tmp/icemaker_global_tempdir.o4pBxOKZHwPg/rustc_testrunner_tmpdir_reporting.DGIJGRHWWShI/mvce.rs:3:14
  |
3 | macro_rules! inline {
  |              ^^^^^^
  |
  = note: `#[warn(unused_macros)]` on by default

warning: crate-level attribute should be an inner attribute: add an exclamation mark: `#![foo]`
 --> /tmp/icemaker_global_tempdir.o4pBxOKZHwPg/rustc_testrunner_tmpdir_reporting.DGIJGRHWWShI/mvce.rs:1:1
  |
1 | #[crate_name = concat!("Cloneb")]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_attributes)]` on by default

warning: 2 warnings emitted

note: no errors encountered even though delayed bugs were created

note: those delayed bugs will now be shown as internal compiler errors

error: internal compiler error: expr in place where literal is expected (builtin attr parsing)
 --> /tmp/icemaker_global_tempdir.o4pBxOKZHwPg/rustc_testrunner_tmpdir_reporting.DGIJGRHWWShI/mvce.rs:1:14
  |
1 | #[crate_name = concat!("Cloneb")]
  |              ^
  |
note: delayed at compiler/rustc_attr_parsing/src/parser.rs:359:24
         0: <rustc_errors::DiagCtxtInner>::emit_diagnostic
         1: <rustc_errors::DiagCtxtHandle>::emit_diagnostic
         2: <rustc_span::ErrorGuaranteed as rustc_errors::diagnostic::EmissionGuarantee>::emit_producing_guarantee
         3: <rustc_errors::DiagCtxtHandle>::span_delayed_bug::<rustc_span::span_encoding::Span, &str>
         4: <rustc_attr_parsing::parser::MetaItemParser>::from_attr
         5: <rustc_resolve::def_collector::DefCollector as rustc_ast::visit::Visitor>::visit_item
         6: <rustc_resolve::def_collector::DefCollector as rustc_ast::visit::Visitor>::visit_crate
         7: <rustc_resolve::Resolver as rustc_expand::base::ResolverExpand>::visit_ast_fragment_with_placeholders
         8: <rustc_expand::expand::MacroExpander>::collect_invocations
         9: <rustc_expand::expand::MacroExpander>::fully_expand_fragment
        10: <rustc_expand::expand::MacroExpander>::expand_crate
        11: rustc_interface::passes::resolver_for_lowering_raw
        12: rustc_query_impl::plumbing::__rust_begin_short_backtrace::<rustc_query_impl::query_impl::resolver_for_lowering_raw::dynamic_query::{closure#2}::{closure#0}, rustc_middle::query::erase::Erased<[u8; 16]>>
        13: <rustc_query_impl::query_impl::resolver_for_lowering_raw::dynamic_query::{closure#2} as core::ops::function::FnOnce<(rustc_middle::ty::context::TyCtxt, ())>>::call_once
        14: rustc_query_system::query::plumbing::try_execute_query::<rustc_query_impl::DynamicConfig<rustc_query_system::query::caches::SingleCache<rustc_middle::query::erase::Erased<[u8; 16]>>, false, false, false>, rustc_query_impl::plumbing::QueryCtxt, false>
        15: rustc_query_impl::query_impl::resolver_for_lowering_raw::get_query_non_incr::__rust_end_short_backtrace
        16: rustc_interface::passes::create_and_enter_global_ctxt::<core::option::Option<rustc_interface::queries::Linker>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2}>::{closure#2}::{closure#0}
        17: rustc_interface::interface::run_compiler::<(), rustc_driver_impl::run_compiler::{closure#0}>::{closure#1}
        18: std::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface::util::run_in_thread_with_globals<rustc_interface::util::run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<(), rustc_driver_impl::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>
        19: <<std::thread::Builder>::spawn_unchecked_<rustc_interface::util::run_in_thread_with_globals<rustc_interface::util::run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<(), rustc_driver_impl::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>::{closure#1} as core::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
        20: std::sys::pal::unix::thread::Thread::new::thread_start
        21: <unknown>
        22: <unknown>
 --> /tmp/icemaker_global_tempdir.o4pBxOKZHwPg/rustc_testrunner_tmpdir_reporting.DGIJGRHWWShI/mvce.rs:1:14
  |
1 | #[crate_name = concat!("Cloneb")]
  |              ^

error: internal compiler error: expr in place where literal is expected (builtin attr parsing)
 --> /tmp/icemaker_global_tempdir.o4pBxOKZHwPg/rustc_testrunner_tmpdir_reporting.DGIJGRHWWShI/mvce.rs:1:1
  |
1 | #[crate_name = concat!("Cloneb")]
  | ^^^^^^^^^^^^^^
  |
note: delayed at /rustc/ac91805f3179fc2225c60e8ccf5a1daa09d43f3d/compiler/rustc_attr_parsing/src/context.rs:336:43
         0: <rustc_errors::DiagCtxtInner>::emit_diagnostic
         1: <rustc_errors::DiagCtxtHandle>::emit_diagnostic
         2: <rustc_span::ErrorGuaranteed as rustc_errors::diagnostic::EmissionGuarantee>::emit_producing_guarantee
         3: <rustc_errors::DiagCtxtHandle>::span_delayed_bug::<rustc_span::span_encoding::Span, &str>
         4: <rustc_resolve::def_collector::DefCollector as rustc_ast::visit::Visitor>::visit_item
         5: <rustc_resolve::def_collector::DefCollector as rustc_ast::visit::Visitor>::visit_crate
         6: <rustc_resolve::Resolver as rustc_expand::base::ResolverExpand>::visit_ast_fragment_with_placeholders
         7: <rustc_expand::expand::MacroExpander>::collect_invocations
         8: <rustc_expand::expand::MacroExpander>::fully_expand_fragment
         9: <rustc_expand::expand::MacroExpander>::expand_crate
        10: rustc_interface::passes::resolver_for_lowering_raw
        11: rustc_query_impl::plumbing::__rust_begin_short_backtrace::<rustc_query_impl::query_impl::resolver_for_lowering_raw::dynamic_query::{closure#2}::{closure#0}, rustc_middle::query::erase::Erased<[u8; 16]>>
        12: <rustc_query_impl::query_impl::resolver_for_lowering_raw::dynamic_query::{closure#2} as core::ops::function::FnOnce<(rustc_middle::ty::context::TyCtxt, ())>>::call_once
        13: rustc_query_system::query::plumbing::try_execute_query::<rustc_query_impl::DynamicConfig<rustc_query_system::query::caches::SingleCache<rustc_middle::query::erase::Erased<[u8; 16]>>, false, false, false>, rustc_query_impl::plumbing::QueryCtxt, false>
        14: rustc_query_impl::query_impl::resolver_for_lowering_raw::get_query_non_incr::__rust_end_short_backtrace
        15: rustc_interface::passes::create_and_enter_global_ctxt::<core::option::Option<rustc_interface::queries::Linker>, rustc_driver_impl::run_compiler::{closure#0}::{closure#2}>::{closure#2}::{closure#0}
        16: rustc_interface::interface::run_compiler::<(), rustc_driver_impl::run_compiler::{closure#0}>::{closure#1}
        17: std::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface::util::run_in_thread_with_globals<rustc_interface::util::run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<(), rustc_driver_impl::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>
        18: <<std::thread::Builder>::spawn_unchecked_<rustc_interface::util::run_in_thread_with_globals<rustc_interface::util::run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<(), rustc_driver_impl::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>::{closure#1} as core::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
        19: std::sys::pal::unix::thread::Thread::new::thread_start
        20: <unknown>
        21: <unknown>
 --> /tmp/icemaker_global_tempdir.o4pBxOKZHwPg/rustc_testrunner_tmpdir_reporting.DGIJGRHWWShI/mvce.rs:1:1
  |
1 | #[crate_name = concat!("Cloneb")]
  | ^^^^^^^^^^^^^^

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: please make sure that you have updated to the latest nightly

note: rustc 1.87.0-nightly (ac91805f3 2025-02-26) running on x86_64-unknown-linux-gnu

note: compiler flags: --crate-type lib -Z dump-mir-dir=dir

query stack during panic:
end of query stack

[matthiaskrgr]

smaller

#[crate_name = concat !()]
macro_rules !a {
  () => {}
}
fn main() {}

[cyrgani]

cc @jdonszelmann

[jdonszelmann]

Here we go again 😂. @rustbot claim

[jdonszelmann]

Ah, crate_name probably has similar exceptions as crate type from last time. I know how to fix so that's good :)

[fmease]

Ah, crate_name probably has similar exceptions as crate type from last time.

Yes :) albeit more recent and even stricter: #127581 (merged two weeks ago) :D

[apiraino]

Assigning priority (discussion on Zulip).

@rustbot label -I-prioritize +P-high

[fmease]

Nota bene: Matthias's ICE != the 3 ICEs from the crater regression! Matthias's ICE triggers the delayed_span_bugs found in compiler/rustc_attr_parsing/src/parser.rs:359:24 and compiler/rustc_attr_parsing/src/context.rs:336:43 while the crater regressions and theemathas's MCVE trigger a different one, namely compiler/rustc_attr_parsing/src/parser.rs:498:34.

This is relevant/important because PR #124141 unintentionally fixed the crater regressions on master but not Matthias's issue (of which we don't know if it's likely to be hit by real users and thus worth hotfixing on beta). For that, subscribe to draft PR #140584.

[jieyouxu]

NOTE: reading two separate issues in a trenchcoat is really confusing me, so I pulled out the crater regression into a separate issue #140612 to make it clear we're tracking two different issues. I've reproduced the comments pertaining to the crater regressions in #140612, and I'll mark the comment pertaining to the crater regressions on this issue as off-topic to prevent it from being way too confusing. I'll also update the PRs that backlink this issue if suitable.

[jieyouxu]

Re. this regression, we may want to revisit its prioritization.
@rustbot label: -P-high +I-prioritize