Skip to content

Commit dcc2027

Browse files
oli-obkwesleywiser
andauthored
Apply suggestions from code review
Co-authored-by: Wesley Wiser <[email protected]>
1 parent f0bae67 commit dcc2027

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/librustc_middle/mir/mod.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -77,14 +77,14 @@ impl<'tcx> HasLocalDecls<'tcx> for Body<'tcx> {
7777
/// dialects forbid certain variants or values in certain phases.
7878
///
7979
/// Note: Each phase's validation checks all invariants of the *previous* phases' dialects. A phase
80-
/// that changes the dialect documents what invariants must be uphelpd *after* that phase finishes.
80+
/// that changes the dialect documents what invariants must be upheld *after* that phase finishes.
8181
///
8282
/// Warning: ordering of variants is significant.
8383
#[derive(Copy, Clone, TyEncodable, TyDecodable, Debug, PartialEq, Eq, PartialOrd, Ord)]
8484
#[derive(HashStable)]
8585
pub enum MirPhase {
8686
Build = 0,
87-
// FIXME: it's unclear whether we still need this phase (and its corresponding query).
87+
// FIXME(oli-obk): it's unclear whether we still need this phase (and its corresponding query).
8888
// We used to have this for pre-miri MIR based const eval.
8989
Const = 1,
9090
/// This phase checks the MIR for promotable elements and takes them out of the main MIR body

src/librustc_mir/transform/const_prop.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -857,7 +857,7 @@ impl<'mir, 'tcx> ConstPropagator<'mir, 'tcx> {
857857

858858
if let Some(Some(alloc)) = alloc {
859859
// Assign entire constant in a single statement.
860-
// We can't use aggregates, as we are post-aggregate-lowering.
860+
// We can't use aggregates, as we run after the aggregate-lowering `MirPhase`.
861861
*rval = Rvalue::Use(Operand::Constant(Box::new(Constant {
862862
span: source_info.span,
863863
user_ty: None,

0 commit comments

Comments
 (0)